lcftrans: preserve DEL (0x7F) in extracted msgid#107
Open
lucasmachine wants to merge 1 commit intoEasyRPG:masterfrom
Open
lcftrans: preserve DEL (0x7F) in extracted msgid#107lucasmachine wants to merge 1 commit intoEasyRPG:masterfrom
lucasmachine wants to merge 1 commit intoEasyRPG:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some translated strings are not applied because the extracted
msgidis missing a leading byte that exists in the game data.This was reproduced with the RPG Maker 2000/2003 game 水たまりの彼女.
In affected event messages, a leading DEL (
0x7F) byte is present in map data, but was removed during extraction, so EasyRPG Player could not match the translation and fell back to original Japanese text.Root Cause
Utils::RemoveControlCharsremoved both:0x00-0x1F)0x7F)For this game, DEL (
0x7F) is meaningful as a message prefix, so removing it causesmsgidmismatch.Fix
Keep DEL (
0x7F) in extracted strings, while still removing C0 control bytes (0x00-0x1F).Scope
Changed File
lcftrans/src/utils.cppUtils::RemoveControlChars: stop removing0x7F, continue removing0x00-0x1FVerification
msgidnow keeps the leading DEL byte