Skip to content

test: add Go CLI test harness; remove superseded integration targets - #571

Merged
kmannislands merged 2 commits into
mainfrom
giles-cli-tests
Jun 17, 2026
Merged

test: add Go CLI test harness; remove superseded integration targets#571
kmannislands merged 2 commits into
mainfrom
giles-cli-tests

Conversation

@gilescope

@gilescope gilescope commented Jun 14, 2026

Copy link
Copy Markdown

less to go wrong, faster

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope
gilescope requested a review from a team as a code owner June 14, 2026 12:48
@gilescope
gilescope requested review from kmannislands and removed request for a team June 14, 2026 12:48
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

⚠️ Are we earthbuild yet?

Warning: "earthly" occurrences have increased by 21 (0.4%)

📈 Overall Progress

Branch Total Count
main 5315
This PR 5336
Difference +21 (0.4%)

📁 Changes by file type:

File Type Change
Go files (.go) ❌ +17
Documentation (.md) ➖ No change
Earthfiles ❌ +4

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates several Earthfile-based integration tests (such as builtin-args, let-scope, let-set, infinite-recursion, and cache-cmd) into a new Go-based CLI test suite in tests/cli/cli_test.go, accompanied by corresponding test fixtures. The review feedback suggests using a stable Go version (like 1.23 instead of 1.25) in the generated go.mod fixture to prevent build failures, and recommends avoiding if statements with initializers to comply with potential linting rules.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/cli/cli_test.go
Comment thread tests/cli/cli_test.go
Comment thread tests/cli/cli_test.go
@gilescope gilescope mentioned this pull request Jun 15, 2026
12 tasks
@kmannislands
kmannislands enabled auto-merge (squash) June 17, 2026 16:31
@kmannislands
kmannislands merged commit 2656509 into main Jun 17, 2026
89 checks passed
@kmannislands
kmannislands deleted the giles-cli-tests branch June 17, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants