test: add Go CLI test harness; remove superseded integration targets - #571
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
|
| Branch | Total Count |
|---|---|
| main | 5315 |
| This PR | 5336 |
| Difference | +21 (0.4%) |
📁 Changes by file type:
| File Type | Change |
|---|---|
| Go files (.go) | ❌ +17 |
| Documentation (.md) | ➖ No change |
| Earthfiles | ❌ +4 |
Keep up the great work migrating from Earthly to Earthbuild! 🚀
💡 Tips for finding more occurrences
Run locally to see detailed breakdown:
./.github/scripts/count-earthly.shNote that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.
There was a problem hiding this comment.
Code Review
This pull request migrates several Earthfile-based integration tests (such as builtin-args, let-scope, let-set, infinite-recursion, and cache-cmd) into a new Go-based CLI test suite in tests/cli/cli_test.go, accompanied by corresponding test fixtures. The review feedback suggests using a stable Go version (like 1.23 instead of 1.25) in the generated go.mod fixture to prevent build failures, and recommends avoiding if statements with initializers to comply with potential linting rules.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
less to go wrong, faster