Skip to content

fix: data race squashed - #567

Merged
janishorsts merged 3 commits into
mainfrom
giles-fix-stringutil-race
Jun 18, 2026
Merged

janishorsts merged 3 commits into
mainfrom
giles-fix-stringutil-race

Conversation

@gilescope

Copy link
Copy Markdown

No description provided.

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope
gilescope requested a review from a team as a code owner June 14, 2026 12:03
@gilescope
gilescope requested review from kmannislands and removed request for a team June 14, 2026 12:03

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves a concurrency issue in the proto_enum.go utility by constructing stateful casers (cases.Title and cases.Lower) on each function call rather than sharing global instances across goroutines. It also introduces a concurrent test to verify this safety. The reviewer correctly pointed out a compilation error in the new test, where wg.Go is incorrectly called on a standard sync.WaitGroup instead of using standard goroutines with wg.Add and wg.Done.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread util/stringutil/proto_enum_test.go
@github-actions

github-actions Bot commented Jun 14, 2026 •

Copy link
Copy Markdown

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch Total Count
main 5336
This PR 5336
Difference +0

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

@gilescope gilescope mentioned this pull request Jun 14, 2026
12 tasks
@janishorsts
janishorsts enabled auto-merge (squash) June 17, 2026 16:54
@janishorsts
janishorsts merged commit 7fc8f9c into main Jun 18, 2026
89 checks passed
@janishorsts
janishorsts deleted the giles-fix-stringutil-race branch June 18, 2026 07:18
@janishorsts janishorsts mentioned this pull request Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants