fix: data race squashed - #567
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request resolves a concurrency issue in the proto_enum.go utility by constructing stateful casers (cases.Title and cases.Lower) on each function call rather than sharing global instances across goroutines. It also introduces a concurrent test to verify this safety. The reviewer correctly pointed out a compilation error in the new test, where wg.Go is incorrectly called on a standard sync.WaitGroup instead of using standard goroutines with wg.Add and wg.Done.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
No description provided.