Skip to content

chore(lint): disable deprecated gomodguard - #496

Merged
gilescope merged 5 commits into
mainfrom
chore-disable-gomodguard
May 14, 2026
Merged

gilescope merged 5 commits into
mainfrom
chore-disable-gomodguard

Conversation

@janishorsts

@janishorsts janishorsts commented May 12, 2026

Copy link
Copy Markdown
Collaborator

(includes action pinning)

@janishorsts janishorsts self-assigned this May 12, 2026
@janishorsts
janishorsts requested a review from a team as a code owner May 12, 2026 11:50
@janishorsts
janishorsts requested review from gilescope and removed request for a team May 12, 2026 11:50
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch Total Count
main 5557
This PR 5557
Difference +0

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the gomodguard linter to the .golangci.yaml configuration file. I have no feedback to provide as there are no review comments.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the gomodguard linter to the .golangci.yaml configuration. Feedback indicates that this linter was removed in golangci-lint v1.60.0, and its inclusion will lead to fatal configuration errors in newer versions of the tool.

Comment thread .golangci.yaml

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .golangci.yaml configuration file by adding the gomodguard linter to the list of enabled linters. There are no review comments provided for these changes, and I have no further feedback to provide.

@gilescope
gilescope enabled auto-merge (squash) May 14, 2026 05:19
gilescope added 3 commits May 14, 2026 06:19
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope
gilescope merged commit d8d8dd9 into main May 14, 2026
89 of 90 checks passed
@gilescope
gilescope deleted the chore-disable-gomodguard branch May 14, 2026 07:23
@janishorsts janishorsts mentioned this pull request Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants