fx: for code scanning alert no. 1: Workflow does not contain permissions - #150
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
janishorsts
marked this pull request as ready for review
April 25, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/EarthBuild/dind/security/code-scanning/1
Add an explicit
permissionsblock to the workflow soGITHUB_TOKENis constrained regardless of repository/org defaults.Best fix here: define workflow-level permissions right after the trigger section (
on:), beforejobs::contents: readis sufficient for checking out repository contents.DOCKERHUB_TOKEN, not GitHub write APIs.File to change:
.github/workflows/dockerhub-description.ymlRegion to change:
permissions:block between the existingon:block andjobs:block.No imports/dependencies/methods are needed (YAML config only).
Suggested fixes powered by Copilot Autofix. Review carefully before merging.