Revert "Output GPTL timing info when using NUOPC driver"#4803
Merged
Conversation
sjsprecious
approved these changes
May 22, 2025
sjsprecious
left a comment
sjsprecious
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jedwards4b for reverting this.
The MODEL_THETA_L and HOMME_ENABLE_COMPOSE variables are not applied by default when building the GPTL library. Even if I add them manually, no ESMF or GPTL timing file is generated when using the theta-l dycore in CAM (both ESMF and GPTL timing files are generated correctly when using the theta-l_kokkos dycore in CAM). Thus I think it is better to manually revise this block as needed for different dycores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4791