Fates next api uninitialized hlm_model_day fix#820
Merged
rgknox merged 10 commits intoDec 16, 2019
Conversation
…st appears to be not necessary and second screws up the cold start
…nes. First appears to be not necessary and second screws up the cold start" This reverts commit ac16068.
glemieux
added
FATES API update
ekluzek
requested changes
Dec 16, 2019
ekluzek
left a comment
ekluzek
left a comment
Contributor
There was a problem hiding this comment.
One small request in a comment. But, always good to move related lines of code into a subroutine or function. So this is a great change to get in.
rgknox
approved these changes
Dec 16, 2019
ekluzek
approved these changes
Dec 16, 2019
This was referenced Jul 23, 2020
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jun 27, 2024
Fates next api uninitialized hlm_model_day fix
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jul 5, 2024
Fates next api uninitialized hlm_model_day fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Specific notes
This change fixes an uninitialized variable
hlm_model_day. It was found while trying to run in debug mode on Lawrencium, which builds with the intel compiler option-ftrapuvwhich initializes the variable toNaN. FatesHistoryInterfaceMod.F90 tries to reference the variable and as such, causes a floating invalid error. See also discussion from ESMCI/cime#3205.Contributors other than yourself, if any: @rgknox
CTSM Issues Fixed (include github issue #): NGEET/fates#548
Are answers expected to change (and if so in what way)? Yes
Due to the structure of the
init_coldstartprocedure the model day will be set to one during the initialization (which is technically day zero), resulting in thecleafoff(and related variables) being off by one day compare to the baseline for the initialization step only. Howver, thecleafoffvalues for the timesteps greater than zero all match.Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any:
Comparision testing against CTSM baseline hash. All expected PASS except
ERP_Ld9.f45_f45_mg37.I2000Clm50FatesCruGs.cheyenne_intel.clm-FatesAllVarsdue to changes mentioned above.CTSM baseline hash: 9c12e40
Output location: