Skip to content

fix some st_archive issues with rpointer files#3067

Merged
ekluzek merged 2 commits into
ESCOMP:b4b-devfrom
jedwards4b:st_arvchive_fix
Apr 24, 2025
Merged

fix some st_archive issues with rpointer files#3067
ekluzek merged 2 commits into
ESCOMP:b4b-devfrom
jedwards4b:st_arvchive_fix

Conversation

@jedwards4b

@jedwards4b jedwards4b commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Description of changes

Fix some issues related to timestamp rpointer files not being archived correctly.

Specific notes

Contributors other than yourself, if any: Mike Levy

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? NO

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: will run regular and ctsm_sci
Tested archiving of fully coupled cases with DOUT_S_SAVE_INTERIM_RESTART_FILES: FALSE and
DOUT_S_SAVE_INTERIM_RESTART_FILES: TRUE

@wwieder wwieder added next this should get some attention in the next week or two. Normally each Thursday SE meeting. bug something is working incorrectly labels Apr 15, 2025
@wwieder wwieder added this to the ctsm6.0.0 (code freeze) milestone Apr 15, 2025
@wwieder

wwieder commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Thanks for making this PR @jedwards4b we'll discuss at our weekly meeting.

@ekluzek ekluzek self-assigned this Apr 15, 2025
@ekluzek ekluzek added blocked: dependency Wait to work on this until dependency is resolved PR status: needs testing labels Apr 15, 2025
@ekluzek

ekluzek commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Because this includes submodule updates, this will likely need to follow some other PR's with submodule updates. And the tags for submodules will all need to be done before merging.

@ekluzek ekluzek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is straightforward and makes sense to me.

@ekluzek ekluzek changed the base branch from master to b4b-dev April 16, 2025 22:44
@ekluzek

ekluzek commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

I rebased this to b4b-dev, and maybe the way to do this one, would be to bring this one as it is, and then do the other submodule updates in a different PR. They don't have to be connected together, although they all need to come together in a final tag to get the benefits.

@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Apr 17, 2025
@wwieder wwieder moved this from Ready to start (or start again) to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Apr 17, 2025
@samsrabin samsrabin added b4b bit-for-bit and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Apr 17, 2025
@samsrabin samsrabin linked an issue Apr 17, 2025 that may be closed by this pull request
@wwieder

wwieder commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

@ekluzek will merge this to b4bdev and create issues for the definition of done wrt other components

@wwieder wwieder moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to In progress - b4b-dev in CTSM: Upcoming tags Apr 17, 2025
@ekluzek

ekluzek commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

Since, this is really restricted set of changes, I just ran a case with archiving on, and made sure that worked. Jim's testing already validated the changes.

@ekluzek ekluzek merged commit c29f0cd into ESCOMP:b4b-dev Apr 24, 2025
@ekluzek ekluzek deleted the st_arvchive_fix branch April 24, 2025 03:49
@github-project-automation github-project-automation Bot moved this from In progress - b4b-dev to Done (non release/external) in CTSM: Upcoming tags Apr 24, 2025
ekluzek added a commit to fvitt/CTSM that referenced this pull request May 1, 2025
ekluzek added a commit to ekluzek/CTSM that referenced this pull request May 4, 2025
ekluzek added a commit to ekluzek/CTSM that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit blocked: dependency Wait to work on this until dependency is resolved bug something is working incorrectly PR status: needs testing

Projects

Status: Done (non release/external)
Status: Done

Development

Successfully merging this pull request may close these issues.

rpointer files not moved to st_archiver

4 participants