Handle same file error#2921
Merged
Merged
Conversation
…ng that rpointer files are the same
ekluzek
added
enhancement
ekluzek
approved these changes
Jan 14, 2025
Contributor
|
This is working for the SSP tests, but the SSPMATRIX test that's more complex is not. I first thought that the rpointer updates for at least the cpl need the rest_time to get the right file for DRV_RESTART_POINTER. There's some code in system_test_common.py that I could copy to do that. But, then I realized that the rpointer files for these cases, may not need to be copied for these cases as they aren't continue runs. Previously it was copying ALL of the rpointer files with the generic dates that just meant one file per component, but now with timestamps it could be a bunch for each time restarts are written. |
Copy the logic from other CIME SystemTests about setting the driver rpointer file for branch run types. (requires setting the file and DRV_RESTART_POINTER xml variable).
jedwards4b
commented
Jan 21, 2025
jedwards4b
left a comment
jedwards4b
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM - you just need to run black on cime_config/SystemTests/sspmatrixcn.py
…of the pylint issues
… have to implement run_indv and have a unit test version and actual run version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In some cases of the ssp test the file to copy already exists (when run twice for example)
this leads to an error in shutil.copy. Use a try except clause to avoid this error.
Specific notes
This fix may require ESMCI/cime#4727
Contributors other than yourself, if any:
CTSM Issues Fixed:
Fixes #2913
Fixes #2920
Are answers expected to change (and if so in what way)? NO
Any User Interface Changes (namelist or namelist defaults changes)? NONE
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any: SSP_Ld4.f09_g17.I1850Clm50BgcCrop.derecho_intel.clm-ciso_rtmColdSSP