PPE change to sa_leaf in CanopyFluxesMod.F90#2788
Merged
Merged
Conversation
slevis-lmwg
approved these changes
Sep 25, 2024
Member
|
@wwieder Removing my assignment, as with the change to our queue order I no longer care when this comes in ;-) |
This comment was marked as resolved.
This comment was marked as resolved.
1 task
Contributor
|
Starting aux_clm. |
slevis-lmwg
reviewed
Oct 14, 2024
olyson
commented
Oct 14, 2024
olyson
left a comment
Contributor
Author
There was a problem hiding this comment.
I think "larger than roundoff/same climate" is adequate, and maybe not put "X" in the checkboxes? Unless "significant" means the same thing as "larger than rounoff/same climate". I interpret significant as meaning different climate, which is not what I think we have here. Also, I suggest maybe include a direct link to the diagnostics, instead of indirectly through the issue?
Contributor
|
I have preemptively updated the ChangeLog with aux_clm results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add change to sa_leaf that was in PPE branch but is not on master
Specific notes
Contributors other than yourself, if any: @olyson
CTSM Issues Fixed (include github issue #):
Fixes #2777
Are answers expected to change (and if so in what way)? Yes. See #2777 for results.
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Yes. No.
Testing performed, if any:
No test suite testing thus far.