FATES parameter file and test definition updates#2009
Conversation
These outputs have been converted to pft-level variables. Given that we avoid multiplexed outputs for the baseline fates these are not replaced.
this has been removed with fates pull request 958
|
This is straight forward, we may need to update the name of the parameter files because of an update, but this looks good |
updates for smp_sl
NEON fixes for TOOL and user-mods, add SP for NEON, some history file updates, black refactor for buildlib/buildnml Merge the NEON fixes for TOOL and allowing SP mode, as well as a few simple history PR's, and a black reformat. Fixes NEON bug identified at the NCAR-NEON workshop. Corrects the dominant PFT at TOOL site & usermods_dirs Some small changes for quality of life improvements for the run_neon script. Some documentation and code cleanup type changes regarding history code (delete a unused subroutine). Do a black reformat of python files buildlib/buildnml (and CTSM SystemTests) for consistency across CESM. Also add running them through black in the python Specific notes: - fixed a couple lines so that python will stop complaining about deprecated things - added print statements about warning messages being not an issue, and that building/running may take a while - added a "success" print statement - I'm not sure this will actually only print if "successful" - Add more documentation to history tape code - Add more breadcrumbs between related variables and methods - Put related history namelist flags/methods together - Update some out of date comments in history code
|
Regression testing on cheyenne and izumi is underway. |
rgknox
left a comment
rgknox
left a comment
There was a problem hiding this comment.
Looks good, assuming we will update the Externals pointer to the new fates tag once we integrate the fates-side changes.
|
Testing |
Adds fixed issue id
|
Testing aux_clm on izumi against Folder location: This pull request should be ready to go. |
|
I updated the fates externals tag to include a bug fix. Re-testing using cheyenne: |
ekluzek
added
FATES API update
ekluzek
left a comment
ekluzek
left a comment
There was a problem hiding this comment.
Looks good. Glad you were able to figure this out and get it working.
I only have one comment that I'll make into an issue if it seems worth it.
|
|
||
| do j = 1,nlevsoil | ||
| if(this%fates(nc)%bc_out(s)%active_suction_sl(j)) then | ||
| s_node = max(waterstatebulk_inst%h2osoi_vol_col(c,j)/soilstate_inst%eff_porosity_col(c,j) ,0.01_r8) |
There was a problem hiding this comment.
The 0.01_r8 magic number should likely be made a parameter. But, we should do that later since testing is already in. I'll look at this more carefully, and if I think it's worth doing turn it into an issue.
…nto fates-drdt-decid-updates
3 participants
Description of changes
This PR should be coordinated with FATES pull request NGEET/fates#958. This PR makes updates to the FATES parameter file, changes the namespace of fates history outputs, and updates the fates dynamics driver.
Specific notes
The fates site-level history outputs associated with drought (e.g.
FATES_DROUGHT_STATUS) have been converted to pft-level outputs. As such, the site-level variables have been removed from the basesFatestestmod user namelist and the pft-level variables have been added to theFatesAllVarstest module.A fix for #2043 was included here when it was rediscovered during testing.
Contributors other than yourself, if any: @rgknox
CTSM Issues Fixed (include github issue #): #2043
Are answers expected to change (and if so in what way)? Yes, due to expected scientific updates since the previous fates tag. There will also be
FIELDLISTchanges due to changing history output names.Any User Interface Changes (namelist or namelist defaults changes)? None
Testing performed, if any: regular testing