Skip to content

Switch izumi aux_clm category non-debug fates testmods from nag to intel#1524

Merged
ekluzek merged 8 commits into
ESCOMP:masterfrom
glemieux:fates-testmod-izumi_nag_intel-switch
Oct 18, 2021
Merged

Switch izumi aux_clm category non-debug fates testmods from nag to intel#1524
ekluzek merged 8 commits into
ESCOMP:masterfrom
glemieux:fates-testmod-izumi_nag_intel-switch

Conversation

@glemieux

@glemieux glemieux commented Oct 15, 2021

Copy link
Copy Markdown
Contributor

Description of changes

In ctsm5.1.dev059 I accidentally introduced tests to the izumi aux_clm list that are failing with the nag compiler due to fates issue 771. This PR changes those tests from nag to intel so as to provide parity in coverage between cheyenne and izumi, while avoiding the aforementioned issue.

This PR also takes the opportunity to update the externals pointer to the latest version of fates which includes a fix for a different nag issue. It also removes two tests from the izumi fates suite: a fine grid, 3-day ERP test in the izumi fates testsuite which was failing MEMLEAK sporadically, and the FatesAllVars testmod. After discussion with @ekluzek, based on related comments from @billsacks, and review of alternate coverage, it was agreed that removing these two tests would not be detrimental to overall testing. Finally, it also cleans up some additional out-of-date entries in the expected failures list.

Specific notes

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? Yes, for fates testmods (since the FATES tag updated the science version)

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any: Passes as expected

  • aux_clm cheyenne
  • aux_clm izumi
  • fates izumi
  • fates cheyenne

Also updating fates external to incorporate fix to fates issue 791.
Also paring back SMS Fates Hydro test from izumi aux_clm due to excess of
coverage.  Updating externals to point to latest fates.  Updating Expected
failures list with SMS Fates hydro failure on izumi and out-dated testmod
name.
@glemieux glemieux marked this pull request as ready for review October 15, 2021 21:13
@glemieux

Copy link
Copy Markdown
Contributor Author

Testing on izumi complete. All expected tests pass. All tests b4b with expected exception of fates testmods:
aux_clm folder: /scratch/cluster/glemieux/ctsm-tests/tests_dev060-aux_clm
fates folder: /scratch/cluster/glemieux/ctsm-tests/tests_dev060-fatessuite

Note that the ERS fates hydro test didn't flag as expected failure due type corrected in commit c0a1627.

@glemieux

glemieux commented Oct 16, 2021

Copy link
Copy Markdown
Contributor Author

Testing on cheyenne complete. All expected tests pass. All tests b4b with expected exception of fates testmods for aux_clm (fates suite is b4b since baseline was generated with sci.1.48.0_api.17.0.0):
aux_clm folder: /glade/u/home/glemieux/scratch/ctsm-tests/tests_dev060-aux_clm
fates folder: /glade/u/home/glemieux/scratch/ctsm-tests/tests_dev060-fates

@ekluzek

ekluzek commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Because of the update in the "sci" version of FATES there are tests that change answers on both izumi and cheyenne:

ERP_Ld9.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDefAllVars
ERS_D_Ld5.f09_g17.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
ERS_D_Ld5.f10_f10_mg37.I2000Clm50Fates.cheyenne_intel.clm-FatesColdDef
ERS_D_Mmpi-serial_Ld5.1x1_brazil.I2000Clm50FatesRs.cheyenne_gnu.clm-FatesColdDef
ERS_D_Mmpi-serial_Ld5.1x1_brazil.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
ERS_D_Mmpi-serial_Ld5.5x5_amazon.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
ERS_Ld30.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDefReducedComplexFixedBiogeo
ERS_Ld30.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDefSizeAgeMort
ERS_Ld9.f10_f10_mg37.I2000Clm50FatesCruRsGs.cheyenne_intel.clm-FatesColdDefCH4
SMS_D_Ld5.f10_f10_mg37.I2000Clm45Fates.cheyenne_intel.clm-FatesColdDef
SMS_D_Ld5.f10_f10_mg37.I2000Clm50FatesRs.cheyenne_gnu.clm-FatesColdDef
SMS_D_Ld5.f10_f10_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
SMS_D_Ld5.f10_f10_musgs.I2000Clm50FatesRs.cheyenne_gnu.clm-FatesColdDef
SMS_D_Ld5.f10_f10_musgs.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
SMS_D_Lm6_P144x1.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
SMS_D_Mmpi-serial_Ld5.5x5_amazon.I2000Clm50FatesRs.cheyenne_gnu.clm-FatesColdDef
SMS_D_Mmpi-serial_Ld5.5x5_amazon.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
SMS_Ld5.f10_f10_mg37.I2000Clm45Fates.cheyenne_intel.clm-FatesColdDef
SMS_Ld5.f10_f10_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
SMS_Ld5.f19_g17.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdDef
SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.cheyenne_intel.clm-FatesColdDefHydro

ERS_D_Ld5.f10_f10_mg37.I2000Clm50Fates.izumi_nag.clm-FatesColdDef
ERS_D_Mmpi-serial_Ld5.1x1_brazil.I2000Clm50FatesRs.izumi_nag.clm-FatesColdDef
ERS_D_Mmpi-serial_Ld5_Vnuopc.1x1_brazil.I2000Clm50FatesRs.izumi_nag.clm-FatesColdDef
SMS_D_Ld5.f10_f10_musgs.I2000Clm50FatesRs.izumi_nag.clm-FatesColdDef
SMS_D_Ld5.f45_f45_mg37.I2000Clm51Fates.izumi_nag.clm-FatesColdDef
SMS_D_Mmpi-serial_Ld5.5x5_amazon.I2000Clm50FatesRs.izumi_nag.clm-FatesColdDef

@ekluzek ekluzek merged commit cca7125 into ESCOMP:master Oct 18, 2021
@ekluzek ekluzek deleted the fates-testmod-izumi_nag_intel-switch branch October 18, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

2 participants