LILACSMOKE: Call case.load_env() before building the atm driver#1149
Merged
Conversation
This is needed for the atm driver build to use the correct module environment
Member
Author
|
@ekluzek although this isn't critical like the last LILAC-related PR (it only impacts testing, not what a typical user will experience), the impact is so limited that I feel it's safe to bring it to master without any additional testing. (I have run the one test that it impacts.) Are you okay with this? If so, I'll bring it to master. |
ekluzek
approved these changes
Sep 13, 2020
samsrabin
pushed a commit
to samsrabin/CTSM
that referenced
this pull request
Sep 17, 2024
…aling Alternative vertical scaling of leaf maintenance respiration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In LILACSMOKE test: Call case.load_env() before building the atm driver. This is needed for the atm driver build to use the correct module environment.
Specific notes
Things were working for me, and apparently for @ekluzek and @negin513 , without this change. But this is probably because our default module environment was similar to cime's cheyenne_intel environment. @glemieux was running into trouble because he has intel17 loaded in his default environment (whereas the environment loaded by cime uses intel19). This should fix that issue.
Contributors other than yourself, if any: none
CTSM Issues Fixed (include github issue #): none
Are answers expected to change (and if so in what way)? Answers may change for the LILACSMOKE test, if baselines were generated with a slightly different compiler version than the one loaded by cime. However, I do not expect answer changes.
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any:
.profilewith his, and replaced the contents of my.lmod.ddirectory with his. So this used intel17. This led to the same issue with the LILACSMOKE test that he reported.