Skip to content

Answer changes needed for CESM2.2.0#1100

Merged
ekluzek merged 13 commits into
ESCOMP:masterfrom
ekluzek:cesm220anschng
Aug 10, 2020
Merged

Answer changes needed for CESM2.2.0#1100
ekluzek merged 13 commits into
ESCOMP:masterfrom
ekluzek:cesm220anschng

Conversation

@ekluzek

@ekluzek ekluzek commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Description of changes

Some answer changes and answer changing bug fixes needed for CESM2.2.0

Specific notes

Contributors other than yourself, if any: @billsacks

CTSM Issues Fixed (include github issue #):

Fixes #1101
Fixes #1097
Fixes #1037
Fixes #1004
Fixes #1012
Fixes #1090
Fixes #1089

Are answers expected to change (and if so in what way)? Yes!

Hist and SSP BGC compsets change answers because of the correction of the end year for ndep. You wouldn't think this would matter until you get to the end of the time-sequence -- but it does for the first time-step.

The 2010 compset changes answers because of using the 2000 finidat file rather than 2010

Some finidat files interpolated to the resolution they are designed for. This causes an apparent change of answers when these datasets are used for other resolutions (even though it does NOT for the resolution it's interpolated to)

waccm_offline tests are also changed in order to more closely match the FXHIST tests in CAM.

Any User Interface Changes (namelist or namelist defaults changes)? Yes

finidat files updated, and corresponding fields for finding finidat files (use_init_interp, init_interp_attributes)

Testing performed, if any: regular in process

ekluzek added 7 commits August 6, 2020 16:09
…sing the previous finidat files, since using updated files changes answers for some cases when it gets interpolated another time"

This reverts commit 68e360a.
… it has an apparant change to answers even for cases that dont' run past 2005"

This reverts commit f788210.
@ekluzek ekluzek added priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations PR status: work in progress labels Aug 7, 2020
@ekluzek ekluzek added this to the cesm2.2.0 milestone Aug 7, 2020
@ekluzek ekluzek self-assigned this Aug 7, 2020
@ekluzek

ekluzek commented Aug 7, 2020

Copy link
Copy Markdown
Contributor Author

Eight tests failed in the cheyenne testing:

ERS_D_Ld5_P480x3.f19_g16.I2000Clm50SpGs.cheyenne_intel.clm-waccmx_offline
ERS_Ln9.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.IHistClm50Sp.cheyenne_intel.clm-clm50cam6LndTuningMode_1979Start
SMS_D_Ld1.f09_g17.I1850Clm45BgcCruGs.cheyenne_intel.clm-default
SMS_D_Ld1.f09_g17.I1850Clm50Sp.cheyenne_intel.clm-default
SMS_D_Ld1.f09_g17.I1850Clm50SpCru.cheyenne_intel.clm-default
SMS_D_Ln9_P480x3.f19_g16.IHistClm50Sp.cheyenne_intel.clm-waccmx_offline
SMS_Ln9.ne0ARCTICGRISne30x8_ne0ARCTICGRISne30x8_mt12.IHistClm50Sp.cheyenne_intel.clm-clm50cam6LndTuningMode_1979Start
SMS_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.IHistClm50Sp.cheyenne_intel.clm-clm50cam6LndTuningMode_2013Start

@ekluzek

ekluzek commented Aug 8, 2020

Copy link
Copy Markdown
Contributor Author

All testing is passing now. Following show different answers...

SMS_D_Ld1.f19_g17.I1850Clm45Cn.izumi_gnu.clm-default
SMS_D_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.izumi_nag.clm-crop
SMS_Ld5_D_P48x1.f10_f10_musgs.IHistClm50Bgc.izumi_nag.clm-monthly
ERS_D_Ld5_P480x3.f19_g16.I2000Clm50SpGs.cheyenne_intel.clm-waccmx_offline
ERI_D_Ld9.f10_f10_musgs.I1850Clm45Bgc.cheyenne_gnu.clm-default
ERP_D_Ld5.C96_C96_mg17.IHistClm50BgcCrop.cheyenne_intel.clm-allActive
ERP_D_Ld5.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-allActive
ERP_D_Ld5.f19_g17.IHistClm50SpCru.cheyenne_intel.clm-drydepnomegan
ERP_Ly3_P72x2.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-cropMonthOutput
ERP_P36x2_D_Ld10.f10_f10_musgs.IHistClm50SpG.cheyenne_intel.clm-glcMEC_decrease
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_intel.clm-crop
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm45BgcCru.cheyenne_intel.clm-default
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm45BgcGs.cheyenne_intel.clm-default
ERP_P36x2_D_Ld5.f10_f10_musgs.I1850Clm45Cn.cheyenne_intel.clm-default
ERP_P36x2_Lm13.f10_f10_musgs.IHistClm50Bgc.cheyenne_gnu.clm-monthly
ERP_P36x2_Lm13.f10_f10_musgs.IHistClm50Bgc.cheyenne_intel.clm-monthly
ERS_D_Ld6.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_gnu.clm-clm50CMIP6frc
ERS_D_Ld6.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_intel.clm-clm50CMIP6frc
ERS_Ly3_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropQianGs.cheyenne_gnu.clm-cropMonthOutput
ERS_Ly3_P72x2.f10_f10_musgs.IHistClm50BgcCropG.cheyenne_intel.clm-cropMonthOutput
ERS_Ly5_P144x1.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-cropMonthOutput
ERS_Ly5_P72x1.f10_f10_musgs.IHistClm45BgcCrop.cheyenne_intel.clm-cropMonthOutput
ERS_Ly6_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropQianGs.cheyenne_intel.clm-cropMonthOutput
LCISO_Lm13.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-ciso_monthly
SMS_D.f19_f19_mg17.I2010Clm50Sp.cheyenne_intel.clm-clm50cam6LndTuningMode
SMS_D_Ly6_Mmpi-serial.1x1_smallvilleIA.IHistClm45BgcCropQianGs.cheyenne_intel.clm-cropMonthOutput
SMS_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_gnu.clm-crop
SMS_Ld5.f10_f10_musgs.I1850Clm45BgcCrop.cheyenne_intel.clm-crop
SMS_Lm37.f10_f10_musgs.I1850Clm50SpG.cheyenne_intel.clm-glcMEC_long
SMS_Ly1_Mmpi-serial.1x1_brazil.IHistClm50BgcQianGs.cheyenne_gnu.clm-output_bgc_highfreq

@ekluzek ekluzek merged commit 30e7216 into ESCOMP:master Aug 10, 2020
@ekluzek ekluzek deleted the cesm220anschng branch August 10, 2020 08:28
@samsrabin samsrabin added bug something is working incorrectly science Enhancement to or bug impacting science labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment