fix for zero pressure in nldas2 configuration#159
Merged
Conversation
jedwards4b
approved these changes
Apr 29, 2022
uturuncoglu
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
fix for zero pressure in nldas2 configuration
Specific notes
The problem encountered in nldas2 is that both the mesh had a mask of zero over ocean points and the route handle for the mapping of streams to the model resolution uses zeroregion=ESMF_REGION_TOTAL. As a result, all mapped values over ocean were set to zero. This is a real problem if the variable is surface pressure. Since the values over ocean are never used, the solution is to simply set a valid value of surface pressure over ocean.
Contributors other than yourself, if any: @jedwards4b @uturuncoglu
CDEPS Issues Fixed: None
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb
Any User Interface Changes (namelist or namelist defaults changes): No
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
The following test now passes and gives results that are comparable to mct
SMS_D_Ld1.nldas2_rnldas2_mnldas2.I2000Ctsm50NwpSpNldas.cheyenne_intel.clm-default
Hashes used for testing: ctsm5.1.dev091