cam6_3_098: always pass NDEP from CAM and remove sst specs -- continued#764
Merged
Conversation
… ndep - either from WACCM or from reading in stream data
nusbaume
approved these changes
Mar 14, 2023
cacraigucar
requested changes
Mar 14, 2023
cacraigucar
left a comment
cacraigucar
left a comment
Collaborator
There was a problem hiding this comment.
Your update to setting the namelist is much cleaner and removes the reservations I had about the new namelist parameters. Thanks!
I have one minor revision request to the ChangeLog
|
|
||
| Purpose of changes (include the issue number and title text for each relevant GitHub issue): | ||
|
|
||
| . Resolve issue #104 - Always send Nitrogen-deposition to surface components. |
Collaborator
There was a problem hiding this comment.
We tend to put in the entire path to the issue, so that users can cut/paste in a brower if they want to view the issue.
cacraigucar
approved these changes
Mar 14, 2023
cacraigucar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #735. mvertens:feature/remove_sst_specs was merged to the
head of cam_development. The implementation of new namelist variables for
the NDEP stream is refactored to have buildnml pass those variables to
build-namelist using its -namelist argument. That gives these variables the
same level of precedence that the CAM_NAMELIST_OPTS variables have, i.e.,
they can only be changed with xmlchange commands. Doing it this way
requires no changes to the build-namelist script.
PR #735 has been fully reviewed. No further reviews requested for this PR.
closes #735
closes #104