Improve bitwidth optimization for FTD circuits#959
Draft
AyaElAkhras wants to merge 2 commits into
Draft
Conversation
AyaElAkhras
changed the title
Member
|
What's the relation between this change and #816? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing bitwidth optimization implementation does not work well for FTD-generated circuits, particularly when constants and branch-bound information flow through FTD mux structures.
This PR adds a new
handshake-minimize-cst-widthpass that rewrites Handshake constants to the minimum required integer bitwidth and inserts extension operations to preserve user-facing types.It also updates
handshake-optimize-bitwidthsto: