Skip to content

Feature/emailintoken - #1643

Merged
rakeshSgr merged 5 commits into
ELEVATE-Project:developfrom
borkarsaish65:feature/emailintoken
May 25, 2026
Merged

rakeshSgr merged 5 commits into
ELEVATE-Project:developfrom
borkarsaish65:feature/emailintoken

Conversation

@borkarsaish65

@borkarsaish65 borkarsaish65 commented May 22, 2026 •

Copy link
Copy Markdown
Contributor

Release Notes

  • Added optional email parameter to SessionsHelper.enroll() function to support explicit email specification during session enrollment
  • Updated SessionsHelper.addMentees() to pass mentee email directly to enroll() function instead of relying on userTokenData
  • Enables manager/admin-initiated session enrollment to use email parameter instead of extracting from user token data

Contributor Statistics

Author Additions Deletions
borkarsaish65 6 5

Review Change Stack

@borkarsaish65

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
✅ Actions performed

Full review triggered.

@coderabbitai

coderabbitai Bot commented May 22, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@borkarsaish65 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 35 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf552319-565a-4ea7-a691-2884d65cf670

📥 Commits

Reviewing files that changed from the base of the PR and between 7799751 and 8935514.

📒 Files selected for processing (1)
  • src/services/sessions.js

Walkthrough

The enroll function in SessionsHelper now accepts an optional email parameter instead of extracting email from userTokenData for non-self-enrollment cases. The caller addMentees is updated to pass menteeData.email explicitly to align with the new signature.

Changes

Email parameter refactoring for enrollments

Layer / File(s) Summary
Email parameter refactoring in enroll and addMentees
src/services/sessions.js
SessionsHelper.enroll signature updated to include an optional email parameter after roles; the non-self-enrollment flow no longer assigns email from userTokenData.email; SessionsHelper.addMentees updated to pass menteeData.email as the trailing argument to enroll.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • ELEVATE-Project/mentoring#1358: Both PRs modify src/services/sessions.js enrollment APIs by changing the enroll call signature and how arguments are passed.
  • ELEVATE-Project/mentoring#1480: Both PRs modify src/services/sessions.js enrollment flows by changing the parameter surfaces of SessionsHelper.enroll and addMentees.

Suggested reviewers

  • nevil-mathew

Poem

🐰 An email hops through parameters new,
No more from userTokenData it drew,
Explicit and clear, the mentee's now set,
A cleaner enrollment, no guesswork to fret!
✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Feature/emailintoken' is vague and doesn't clearly communicate the specific change; it uses a branch name format rather than a descriptive summary of the modification. Rename to a descriptive title that clearly explains the change, such as 'Add optional email parameter to SessionsHelper.enroll' or 'Support email override in session enrollment flow'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rakeshSgr
rakeshSgr merged commit be915ae into ELEVATE-Project:develop May 25, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants