Skip to content

Session Completion Parameter fixing - #1560

Merged
nevil-mathew merged 1 commit into
developfrom
BigBlueButton_session_end_parameter_issue
Feb 12, 2026
Merged

nevil-mathew merged 1 commit into
developfrom
BigBlueButton_session_end_parameter_issue

Conversation

@sumanvpacewisdom

@sumanvpacewisdom sumanvpacewisdom commented Feb 11, 2026 •

Copy link
Copy Markdown
Collaborator

Release Notes

Features & Fixes

  • Added tenantCode parameter to BigBlueButton meeting creation to ensure proper session completion callback handling
  • Updated the end meeting callback URL construction to include tenant code as a URL-encoded query parameter for improved session tracking

Changes by Author

Author Lines Added Lines Removed
sumanvpacewisdom 18 3

@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown

Walkthrough

This pull request adds tenantCode parameter support to the BigBlueButton meeting creation flow. The function signature was updated to accept tenantCode, and the callback URL construction was modified to include this parameter as a URL-encoded query string. The sessions service was updated to pass tenantCode when invoking the meeting creation request.

Changes

Cohort / File(s) Summary
BigBlueButton Meeting Creation
src/requests/bigBlueButton.js
Added tenantCode parameter to createMeeting function signature and updated endMeetingCallBackUrl construction to include tenantCode as a URL-encoded query parameter using encodeURIComponent.
Sessions Service
src/services/sessions.js
Updated call to bigBlueButtonRequests.createMeeting in the start method to pass tenantCode alongside existing parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Fetch tenant api #1357 — Both PRs modify the createMeeting call signature and parameter passing flow to support tenant-related data for meeting creation.

Suggested reviewers

  • nevil-mathew

Poem

🐰 A tenant code hops into the fray,
Through meetings it finds its graceful way,
Parameters pass with encoded care,
Sessions and requests now a matching pair!
The blue button brightens with tenant pride! 🔵

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Session Completion Parameter fixing' is vague and does not clearly describe the main change. While it references 'parameter fixing,' it does not specify what parameter, what component, or what problem is being addressed. Revise the title to be more specific, such as 'Add tenantCode parameter to BigBlueButton meeting creation' or 'Include tenantCode in meeting callback URL' to clearly communicate the primary change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BigBlueButton_session_end_parameter_issue

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nevil-mathew
nevil-mathew merged commit bf960a2 into develop Feb 12, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants