Skip to content

Module Api Fix - #1542

Merged
nevil-mathew merged 1 commit into
developfrom
modules_api_issue_fix
Feb 13, 2026
Merged

nevil-mathew merged 1 commit into
developfrom
modules_api_issue_fix

Conversation

@sumanvpacewisdom

@sumanvpacewisdom sumanvpacewisdom commented Jan 20, 2026 •

Copy link
Copy Markdown
Collaborator

…ification comments

Release Notes

Changes

  • Permissions Query Update: Updated the module update flow to remove tenant isolation from permission updates. The permissions query filter now only uses module: modules.code instead of including tenant_code: tenantCode, aligning permission updates with a global/system-level permissions table architecture.
  • Code Documentation: Added clarification comments explaining that the permissions table operates at the global/system level without tenant isolation.

Author Contributions

Author Lines Added Lines Removed
sumanvpacewisdom 3 1

@coderabbitai

coderabbitai Bot commented Jan 20, 2026 •

Copy link
Copy Markdown

Walkthrough

Updated the permission update flow in src/services/modules.js to remove tenant-based scoping. The filter now uses only module instead of both tenant_code and module, aligning with a global permissions table architecture.

Changes

Cohort / File(s) Summary
Permission update scope change
src/services/modules.js
Removed tenant_code from permission update filter; now scopes only by module: modules.code. Reflects shift from tenant-isolated to global permissions table. Added clarifying comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • nevil-mathew

Poem

🐰 The tenant walls fall away today,
Permissions dance in global play,
One filter reigns, the module way,
A simpler scope, come what may! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Module Api Fix' is vague and generic, failing to convey the specific nature of the change (removing tenant_code filtering from permissions queries). Consider a more descriptive title such as 'Remove tenant_code filtering from module permissions query' or 'Update permissions query to use global scope instead of tenant isolation'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sumanvpacewisdom sumanvpacewisdom changed the title Update permissions query to remove tenant_code filtering and add clar… Module Api Fix Jan 27, 2026
@nevil-mathew
nevil-mathew merged commit 9940f16 into develop Feb 13, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants