This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Early return for URLS that are already HTTPS#17010
Merged
jsha merged 1 commit intoEFForg:masterfrom Nov 2, 2018
Merged
Conversation
This follows up on the work in PR EFForg#16924
Collaborator
jsha
approved these changes
Nov 2, 2018
Member
jsha
left a comment
There was a problem hiding this comment.
Note: There are about four rulesets that still potentially rewrite HTTPS-to-HTTPS (that were missed in @zoracon's previous pass due to unusual regexes). However, we've reviewed those and the HTTPS-to-HTTPS rewrites aren't needed anymore, so we can merge this without waiting on the corresponding ruleset PR.
This was referenced Nov 4, 2018
Hainish
added a commit
that referenced
this pull request
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on the work in PR #16924.