Repository navigation
build: raise the measured mcp floor to >=1.21.1 — pydantic 2.14 broke 1.17–1.21.0 (#271) - #272
Merged
Merged
Conversation
…1.17–1.21.0) (#271) pydantic 2.14.0/2.14.1 removed the private eval_type_backport helper that mcp.server.fastmcp imports at module load in 1.17.0 through 1.21.0, so the floor leg (and any fresh install resolving the floor) stopped importing on 2026-10-11 with no change in this repo. Bisected in a clean venv against pydantic 2.14.1: 1.21.1 is the first 1.x that imports; newest 1.x and 2.x are unaffected. Same lesson as #256/#242: a range spec resolves newest, so a declared floor is only true while its neighbours stay put — move the floor, do not pin the neighbour in CI and keep advertising a bound pip cannot honor. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 53 minutes. View limit details
Comment |
8 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271.
Every PR since 2026-10-11 fails
mcp-majors (mcp==1.17.0)at collection: pydantic 2.14 removedpydantic._internal._typing_extra.eval_type_backport, whichmcp.server.fastmcpimports at module load in 1.17.0–1.21.0. Nothing in this repo changed; main was green on 2026-09-21.Measured in a clean uv venv (py3.12, pydantic 2.14.1): 1.17.0–1.21.0 break, 1.21.1 is the first 1.x that imports, 1.30.0 and 2.3.0 are fine. With pydantic 2.13.5 pinned, 1.17.0 still imports — so this is a neighbour moving, not mcp.
pyproject:mcp>=1.21.1,<3(+ the measured-floor comment updated with the why)ci.yml: floor leg pinsmcp==1.21.1, 1.x range leg>=1.21.1,<2mcp/README.md,CLAUDE.md,CHANGELOGUnreleasedWhy not pin
pydantic<2.14inside the CI leg: that keeps advertising a floor a freshpip install kvm-pilotcannot honor — the same fiction #241/#242 removed.Local: ruff, mypy, bandit green; MCP suite (
test_mcp_server,test_mcp_sdk_shim,test_act) passes in a clean venv at exactlymcp==1.21.1+ pydantic 2.14.1.🤖 Generated with Claude Code