Use AsyncServiceScope in Background Services#1736
Merged
Merged
Conversation
…ces using IAsyncDispose
josephdecock
approved these changes
Jan 27, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Dec 1, 2025
This was referenced Dec 1, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes background services from to use
AsyncServiceScopeto support services which implementIAsyncDisposable.It is worth noting we do have one other spot we create a scope. However, the other instance of creating a scope is in code called during startup and is not currently asynchronous. Updating that feels like a breaking change and has been kept out of scope for these changes.