Update Asprire version from 13.3.5 to 13.4.3#35
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the .NET Aspire test/AppHost dependencies used by the Postbode Aspire-based functional test harness, aligning the test projects with Aspire 13.4.3.
Changes:
- Bump
Aspire.Hosting.Testingin the Aspire test project from13.3.5to13.4.3. - Bump
Aspire.Hosting.AppHost,Aspire.Hosting.Azure.ServiceBus, and OSX-specific orchestration/dashboard packages in the Aspire AppHost project from13.3.5to13.4.3.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Droomploeg.Postbode.Aspire.Tests/Droomploeg.Postbode.Aspire.Tests.csproj | Updates the Aspire testing package version used by the test project. |
| tests/Droomploeg.Postbode.Aspire.Tests.AppHost/Droomploeg.Postbode.Aspire.Tests.AppHost.csproj | Updates Aspire AppHost and platform-specific orchestration/dashboard package versions used by the AppHost. |
Comments suppressed due to low confidence (1)
tests/Droomploeg.Postbode.Aspire.Tests.AppHost/Droomploeg.Postbode.Aspire.Tests.AppHost.csproj:24
- The Linux x64 conditional package references are still pinned to Aspire 13.3.5, while the rest of the AppHost packages were bumped to 13.4.3. Mixing Aspire package versions across platform-specific orchestration/dashboard SDKs can lead to restore/runtime incompatibilities on Linux CI runners.
<ItemGroup Condition="$([MSBuild]::IsOSPlatform('Linux')) AND '$([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture)' == 'X64'">
<PackageReference Include="Aspire.Hosting.Orchestration.linux-x64" Version="13.3.5" />
<PackageReference Include="Aspire.Dashboard.Sdk.linux-x64" Version="13.3.5" />
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Linked Issue
Checklist
Architecture
Code Quality
Async_camelCase.editorconfigFunctionality
IAuditLoggerAdapterFactorywith the correct mode (OnBehalfOfvsServiceAccount)ApplicationContextis properly set (CorrelationId, UserName, CurrentConnection)Security
Testing
dotnet buildpassesdotnet testpassesGeneral