Skip to content

Update Asprire version from 13.3.5 to 13.4.3#35

Merged
mvanleijenhorst merged 2 commits into
mainfrom
maintaince/2026-06-09
Jun 9, 2026
Merged

Update Asprire version from 13.3.5 to 13.4.3#35
mvanleijenhorst merged 2 commits into
mainfrom
maintaince/2026-06-09

Conversation

@mvanleijenhorst

@mvanleijenhorst mvanleijenhorst commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Type of Change

  • Fix (bug fix)
  • Add (new feature)
  • Refactor (no behavioral change)
  • Update (dependency / version)
  • Change (behavioral change)
  • Remove (removing code/feature)
  • Docs

Linked Issue

Checklist

Architecture

  • Layer boundaries respected (no implementations in Application, no business logic in WebApp)
  • New interfaces defined in Application; implementations in Infrastructure
  • No direct Azure Service Bus SDK calls from services (must go through adapters)
  • No infrastructure provisioning logic added (queue/topic creation belongs in Bicep)

Code Quality

  • Naming conventions followed (see CONTRIBUTING.md)
  • Async methods suffixed with Async
  • Private fields use _camelCase
  • No unnecessary JavaScript added (Blazor Server preferred)
  • Code style matches .editorconfig

Functionality

  • All message operations are audit-logged via IAuditLogger
  • Long-running operations use the worker/dispatcher pattern (not inline)
  • New adapters use AdapterFactory with the correct mode (OnBehalfOf vs ServiceAccount)
  • ApplicationContext is properly set (CorrelationId, UserName, CurrentConnection)

Security

  • No secrets or credentials committed
  • Authentication/authorization properly applied
  • Token flow correct (On-Behalf-Of for user actions, Managed Identity for service actions)

Testing

  • dotnet build passes
  • dotnet test passes
  • New functionality has appropriate test coverage (functional tests via Aspire)

General

  • Commit messages follow project conventions
  • No unrelated changes included
  • I have read and agree to the CLA

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the .NET Aspire test/AppHost dependencies used by the Postbode Aspire-based functional test harness, aligning the test projects with Aspire 13.4.3.

Changes:

  • Bump Aspire.Hosting.Testing in the Aspire test project from 13.3.5 to 13.4.3.
  • Bump Aspire.Hosting.AppHost, Aspire.Hosting.Azure.ServiceBus, and OSX-specific orchestration/dashboard packages in the Aspire AppHost project from 13.3.5 to 13.4.3.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/Droomploeg.Postbode.Aspire.Tests/Droomploeg.Postbode.Aspire.Tests.csproj Updates the Aspire testing package version used by the test project.
tests/Droomploeg.Postbode.Aspire.Tests.AppHost/Droomploeg.Postbode.Aspire.Tests.AppHost.csproj Updates Aspire AppHost and platform-specific orchestration/dashboard package versions used by the AppHost.
Comments suppressed due to low confidence (1)

tests/Droomploeg.Postbode.Aspire.Tests.AppHost/Droomploeg.Postbode.Aspire.Tests.AppHost.csproj:24

  • The Linux x64 conditional package references are still pinned to Aspire 13.3.5, while the rest of the AppHost packages were bumped to 13.4.3. Mixing Aspire package versions across platform-specific orchestration/dashboard SDKs can lead to restore/runtime incompatibilities on Linux CI runners.
    <ItemGroup Condition="$([MSBuild]::IsOSPlatform('Linux')) AND '$([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture)' == 'X64'">
        <PackageReference Include="Aspire.Hosting.Orchestration.linux-x64" Version="13.3.5" />
        <PackageReference Include="Aspire.Dashboard.Sdk.linux-x64" Version="13.3.5" />

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@mvanleijenhorst mvanleijenhorst merged commit c0cd311 into main Jun 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants