Generic support for unknown record types like CAA#98
Merged
Conversation
pawel-kow
requested review from
kerolasa,
lianapanatau-ionos and
wdbaker-godaddy
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kerolasa
approved these changes
Jul 19, 2024
Collaborator
kerolasa
left a comment
kerolasa
left a comment
There was a problem hiding this comment.
Looks pretty good. Just couple review comments to consider. After that feel free to merge.
Contributor
|
I have reviewed changes with dev and they have approved. |
wdbaker-godaddy
approved these changes
Oct 10, 2024
wdbaker-godaddy
left a comment
wdbaker-godaddy
left a comment
There was a problem hiding this comment.
Approved based on JK comment
Member
Author
|
This change is now under community vote: https://domainconnect.slack.com/archives/CBTKX8R4G/p1736188710187489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a generic support for unknown record types, like CAA or others.
Also JSON schema and template example has beed added for reference.