Skip to content

chore: update the .NET version of the Dockerfile to match csproj - #10

Merged
pieterphilippaerts merged 1 commit into
DistriNet:mainfrom
oliverpool:docker-fix-net-version
Jun 2, 2026
Merged

chore: update the .NET version of the Dockerfile to match csproj#10
pieterphilippaerts merged 1 commit into
DistriNet:mainfrom
oliverpool:docker-fix-net-version

Conversation

@oliverpool

Copy link
Copy Markdown
Contributor

The docker build currently fails, because the .NET version is too old.

This PR fixes this.

@oliverpool

Copy link
Copy Markdown
Contributor Author

I think it would be nice to add containers instructions to the README, to get this running:

cd src/OAuch
podman build -t oauch . # build the container
podman run -p 8443:443 -v ./db:/db oauch:latest # run on https://localhost:8443 and persist the sqlite database in ./db

@pieterphilippaerts
pieterphilippaerts merged commit d893548 into DistriNet:main Jun 2, 2026
@pieterphilippaerts

Copy link
Copy Markdown
Member

Done, thanks for the heads-up!

@oliverpool
oliverpool deleted the docker-fix-net-version branch June 3, 2026 12:03
@oliverpool

Copy link
Copy Markdown
Contributor Author

Thank you for this valuable tool!

Would you be interested in adding continuous integration, to create the container image automatically?
Github offers this for free for open source projects. It would be usable with docker pull ghcr.io/DistriNet/OAuch:<tag>

Example: https://github.com/ranchcomputing/blender-cpu-image/pkgs/container/blender-cpu-image

If yes, I can craft a PR to add this automatic build.

@oliverpool

oliverpool commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

BTW the project has no license!

https://choosealicense.com/licenses/

I would advise GNU AGPLv3 if you want all modifications to be contributed back, for online-accessible instances.
If you do not care about private forks, then MIT would be a sensible choice.

@pieterphilippaerts

Copy link
Copy Markdown
Member

Would you be interested in adding continuous integration, to create the container image automatically? Github offers this for free for open source projects. It would be usable with docker pull ghcr.io/DistriNet/OAuch:<tag>

Example: https://github.com/ranchcomputing/blender-cpu-image/pkgs/container/blender-cpu-image

If yes, I can craft a PR to add this automatic build.

Yes, I would certainly appreciate this. I'm not a big Docker expert or Github Actions expert myself, so I'd definitely could use some help with that :-)

@oliverpool

Copy link
Copy Markdown
Contributor Author

I can make a PR adding a docker build step:

  • every push a build happens
  • only on tag will the build be published

Let me know when you have chose a license (appears in the container manifest).

@pieterphilippaerts

Copy link
Copy Markdown
Member

The license is set. As for the PR, I think it's best to only publish when a build is tagged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants