Skip to content

feat(web): remove Browser from the surface picker - #14

Merged
Dillpickleschmidt merged 1 commit into
mainfrom
feat/remove-browser-surface-card
Aug 1, 2026
Merged

Dillpickleschmidt merged 1 commit into
mainfrom
feat/remove-browser-surface-card

Conversation

@Dillpickleschmidt

@Dillpickleschmidt Dillpickleschmidt commented Aug 1, 2026 •

Copy link
Copy Markdown
Owner

Browser previews are desktop-only, so on web the "Open a surface" grid always rendered a permanently disabled Browser card.

Dropped it from the grid, along with the now-unused onAddBrowser and browserAvailable props on RightPanelEmptyState.

Scope is the card alone. Browser stays in the "+" menu, keeps its six preview.* keybindings, and existing browser surfaces are unaffected — Globe2, SURFACE_DISABLED_REASONS.browser, and both props remain live on the parent, which the menu still uses. Left a comment at the component so its absence from the grid does not read as an oversight.

Deliberately not the general "hide unavailable cards" refactor: showing a disabled card with a tooltip is intentional elsewhere, since it tells the user the feature exists and why it is unavailable.

Note for review

AGENTS.md asks for before/after images on UI changes and I have not attached any — it needs a browser session, which I have not been given the go-ahead for. The visible change is one card removed from a grid-cols-2, taking it from four cards to three, so the grid is briefly ragged until the 3D surfaces land and restore a 2×2. Happy to attach screenshots on request.

Typecheck clean, vp lint clean, rightPanelStore.test.ts 27 passed. No test covers the picker's card list directly.

Closes #3.

Model: Claude Opus 5 via Claude Code.

🤖 Generated with Claude Code

Note

Remove Browser from the web surface picker in the right panel

Removes the Browser action from RightPanelEmptyState in RightPanelTabs.tsx, since Browser surfaces are desktop-only. The onAddBrowser and browserAvailable props are deleted and a comment is added to document the intentional omission.

Macroscope summarized 5a79266.

Browser previews are desktop-only, so on web the "Open a surface" grid
always rendered a permanently disabled Browser card. Drop it from the
grid.

Scope is the card alone. Browser stays in the "+" menu, keeps its
preview.* keybindings, and existing browser surfaces are unaffected;
elsewhere a disabled card with a tooltip is deliberate, since it tells
the user the feature exists and why it is unavailable.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Dillpickleschmidt
Dillpickleschmidt merged commit 36f36f5 into main Aug 1, 2026
2 checks passed
@Dillpickleschmidt
Dillpickleschmidt deleted the feat/remove-browser-surface-card branch August 1, 2026 03:13
@Dillpickleschmidt

Copy link
Copy Markdown
Owner Author

Before / after

Captured from a real client per AGENTS.md, against an isolated dev environment seeded from real data.

Before — Browser present but permanently disabled on web, four cards in a clean 2×2:

surface picker before

After — Browser gone, three cards:

surface picker after

The greyed-out Browser card in the first image is exactly the thing this removed: on web it could never be clicked, only hovered for a tooltip explaining it is desktop-only.

Also visible is the consequence noted at merge time — the grid is grid-cols-2, so dropping to three cards leaves Diff orphaned on its own row. Adding 3D Watch Agent restores a clean 2×2; adding 3D Diff as well makes it five and ragged again. That belongs with whatever lands the new cards, not here.

Images live on the assets/pr-14-screenshots branch rather than main, to keep binaries out of the tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the Browser card from the surface picker

1 participant