Skip to content

feat: add role administration unavailable boundary (#600) - #768

Open
King028 wants to merge 36 commits into
DigiNodes:mainfrom
King028:main
Open

King028 wants to merge 36 commits into
DigiNodes:mainfrom
King028:main

Conversation

@King028

@King028 King028 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes: #600
Head SHA reviewed: <full SHA of your latest commit>## Linked task

Closes:
Head SHA reviewed: <!-- full SHA -->

Summary

Scope and assignment

  • The linked issue has the exact Stellar Wave label.
  • The PR author is assigned or explicitly approved by a maintainer.
  • This PR resolves one task and all dependencies are safely completed.

Architecture, UX, and security

  • Optimism/EVM wallet tooling and canonical ABI/address artifacts are used.
  • No fabricated calldata, gas, transaction hash, receipt, reward, reputation, or settlement is presented.
  • Contracts remain authoritative and the API remains a projection/read layer.
  • Unsupported chain, missing configuration, stale critical data, rejection, revert, replacement, finality, and reorg states fail safely.
  • Keyboard, focus, screen-reader, responsive, and reduced-motion behavior was considered.
  • No Stellar/Soroban/Freighter runtime, secret, placeholder address, or production mock is bundled.

Validation

  • Lint, typecheck, unit tests, and production build pass.
  • Wallet/provider integration tests pass.
  • Accessibility and E2E tests pass.
  • Bundle, dependency, security, and artifact-drift checks pass.
  • Required human CODEOWNER approval applies to this exact head SHA.

@King028
King028 requested a review from dDevAhmed as a code owner October 21, 2026 13:55
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@King028

King028 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

I've have successfully fixed the assigned issue that was given to me.

@dDevAhmed

Copy link
Copy Markdown
Contributor

@King028 add the issue reference in the pull request description and resolve the conflicts.

@King028
King028 marked this pull request as draft October 21, 2026 14:44
@King028
King028 marked this pull request as ready for review October 22, 2026 13:19
@King028

King028 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

This is ready for review. Summary of where it stands:
pnpm type-check passes for everything in this PR (the only remaining errors are pre-existing, unrelated to this change — ClaimContent.tsx, TimelineOfEvents.tsx, useTelemetry.test.ts).
pnpm test -- RoleAdministration passes, 5/5.
Implements the explicit "unavailable" boundary per ADMIN_AUTHORITY_BOUNDARY.md's implementation approval rule, since #600 doesn't yet link the exact contract function/authorization check/audit event/release-manifest field a working mutation flow would need (those depend on #560, which isn't complete yet).
Two things flagged honestly in the PR description, not hidden:
pnpm lint currently crashes repo-wide on an unrelated file (analytics-consent.test.tsx) due to an eslint-plugin-react/ESLint version incompatibility — reproduces on a clean checkout before my changes, so not something this PR caused.
isAuthorized in the new hook is hardcoded to fail closed (false) with a TODO — I didn't want to guess at this codebase's real wallet/session check for a governance-authority gate, so it's left visibly unwired rather than wired incorrectly.

@King028

King028 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the merge conflicts and added the issue reference (Closes: #600).
Updated the head SHA in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI-FE-030 — Build Governance Role Administration UI

2 participants