[felixumeh]

##closes #402

Linked task

Closes: #402
Head SHA reviewed: 076bb8684a58b70a84e4a37d8e86bb5d1d1c27bb

Summary

This PR repairs the sources that stop the frontend gates from executing at all, and makes the claims-list work (V2-FE-109) contract-correct. It was produced by running the CI checks locally — lint, type-check, the Jest suites, and the Playwright spec inventory — and fixing what they actually failed on, rather than assuming the baseline was healthy.

Baseline measured on main @ 9d200c7 (the base this work started from):

Gate	Result on main
npm run lint	Crashed before linting: A configuration object specifies rule "jsx-a11y/alt-text", but could not find plugin "jsx-a11y" (Jest .snap files matched the **/__tests__/**/* rule block)
npm run type-check	500 errors across 115 files, including 26 imports of modules that do not exist
npm run test	Every suite failed at collection: ReferenceError: NEXT_PUBLIC_CHAIN_ID is not defined from src/app/lib/env.ts, loaded through next.config.ts
playwright test --list	The production route smoke spec had 102 syntax errors (smart quotes plus a broken template literal)
CI run 39328267623 on main	Lint, Accessibility, Artifacts, and CSP/provider-drift jobs all failed

Motivation

Several merges left main in a state where no check could run: 5237cf7 (merge of feat/v2-fe-109-active-claims-table-ownership) concatenated two different versions of src/app/(dashboard)/page.tsx, a set of files were committed truncated mid-JSX, and env.ts was shipped referencing NEXT_PUBLIC_* as if they were declared identifiers. Because eslint src and jest both die at load time, every downstream gate is skipped, so these defects have stayed invisible in review.

Changes

1. Merge-corrupted and truncated sources

File	Defect	Repair
src/app/(dashboard)/page.tsx	Two pages concatenated by merge 5237cf7: a public landing page fused with fragments of the old claimant dashboard	Restored the public landing page (67aa6b9 established it as the home route), kept the public dispute register entry point from #702, added the #main-content landmark the route smoke spec asserts, and moved the landing onto claims.envelope
src/app/(dashboard)/claims/[id]/page.tsx	Unclosed div, h-ten typo, VerificationActions missing its required stakeAmount, implicitly-any handlers	Balanced the markup, passed the live stakeAmount, typed the getClaimById handlers, and made the rejection check instanceof Error
src/components/auth/SiweSessionPanel.tsx	File truncated inside useMemo; the container half was missing	Completed the container against the real useSiweAuth return shape (toSiweSignInIntent, ConnectButton slot, correct SiweSignInIntent type name)
src/components/features/admin-dashboard/AdminDashboard.tsx	ref=errorSummaryRef} — invalid JSX that blocked the whole file	ref={errorSummaryRef}
src/__tests__/accessibility/transaction-states.test.tsx	expect(onRetry).toH`aveBeenCalledTimes(1);	expect(onRetry).toHaveBeenCalledTimes(1)
e2e/e2e/production-route-smoke.spec.ts	@playwright/test imported with smart quotes; test(`${route.name}… missing backticks	Rewrote with straight quotes and a valid template literal; playwright test --list now reports 14 tests
8 governance-role files (RoleAdministration, its story and test, RoleMemberList, PendingRoleChangeList, AuthoritySourceSummary, GrantRevokePreparationForm, RoleAdministrationUnavailableState)	Each truncated at ~30 lines, mid-statement	Completed against src/app/types/governance-roles.ts and useRoleAdministrationData: loading/empty/unavailable states, authoritative source-class table, timelock labelling, and a preparation form whose submission stays disabled

2. Runtime blockers

src/app/lib/env.ts — NEXT_PUBLIC_CHAIN_ID and friends were used as bare identifiers inside validateEnv, so the module threw ReferenceError on import. That single defect failed every Jest suite and blocked next.config.ts. Also added the assertProductionEnv export that next.config.ts already imported (it did not exist on this base), and validate supported chain IDs from wagmi/chains instead of a nonexistent chains export from wagmi.

src/app/lib/format.ts — formatLocalDateTime / formatUtcDateTime were imported by protocol-time.ts, ClaimSettlement.tsx, and both worldcoin cards but never existed; formatRelativeAge and getPaginationWindow were specified by claim-list.helpers.test.ts but also missing. Added all four, removed re-exports of formatRelativeTime / formatTimeZone / formatWalletAddress (never present in @/lib/format), and fixed hour: "two-digit" → "2-digit" and Intl.DateTimeFormatPartType → Intl.DateTimeFormatPartTypes.

3. Claims-list contract (V2-FE-109)

Behaviour	Before	After
Row-count range	Derived from requested pageSize → a 1-row page read "Showing 1–10 of 42 claims"	Derived from rendered rows → "Showing 1–1 of 42 claims"
Filter/page change	Table collapsed into the skeleton on every keystroke and chip toggle, dropping focus	placeholderData: keepPreviousData keeps the projection on screen until the next resolves
Freshness	Only API-supplied freshness marked a projection stale	An envelope generated longer ago than staleAfterMs is reported ready-stale
Query failure	error regardless of context	classifyClaimsListError maps PROJECTION_STALE to ready-stale; everything else fails closed to error
Caller params	Unknown params silently ignored	Unsupported parameters fail closed (query disabled, never sent to the wire)

4. Accessibility

• ConfidenceMeter dropped the role="region" wrapper. Rendering one landmark per table row tripped axe's landmark-unique; the accessible name stays on the <meter>, so nothing is lost for assistive tech.
• ActiveClaimsTable scroll container is now a labelled, keyboard-focusable region (role="region", aria-label, tabIndex={0}, min-w-[640px]) so the horizontal data table can be scrolled without a pointer (WCAG 2.1.1). The search row now stacks full-width below sm and can shrink instead of overflowing.
• eslint.config.mjs — two configuration fixes that unblock the lint gate itself, both justified in-file: ignore **/*.snap (generated artifacts matching the __tests__ rule block crash plugin resolution), and exclude src/testing/** from the fixture-import boundary (it is test-only harness code, not production).

5. Test-suite repairs

• Six suites (useClaimSubmissionWizard, evidence, validation, privileged-separation, ClaimDetailsStep, RoleAdministration) imported vitest, which cannot be loaded from a CommonJS Jest run; converted to Jest globals.
• mobile-workflows (accessibility + responsive) and PublicClaimantJourney still rendered <ActiveClaimsTable /> with no props and expected fetch-driven rows. Per docs/ACTIVE_CLAIMS_TABLE_ARCHITECTURE.md, query behaviour belongs to ActiveClaimsTableContainer; the journey harness now feeds canonical ClaimListItem fixtures.
• useClaimsList.test.tsx was updated to the hook's real result shape (envelope) and param names (initialPage), while keeping the fail-closed assertion for unsupported params.
• Added stakeAmount to the VerificationActions call in the claim-detail page.

Merge with upstream/main

upstream/main moved 34 commits while this branch was open, including its own 807f017 Restore frontend CI baseline. The merge had a single conflict, in src/app/lib/env.ts, and it was resolved by de-duplicating assertProductionEnv: after the merge the file exported three copies (two of them from upstream, one unconditional validator that returns Env). An unconditional guard is wrong here — next.config.ts calls it on every target, so it would fail next build for development and test. The merged file keeps exactly one production-only, void-returning guard.

Numbers below are measured on the merged tree.

Verification

Run locally against the final files; exit statuses are captured directly, not via output filters.

npx jest --silent --ci --forceExit <10 suites>
  → 10 suites / 131 tests passed, exit 0
    protocol-time (32), ActiveClaimsTable container (14), useClaimsList (11),
    claim-list.helpers (23), SiweSessionPanel, RoleAdministration,
    claims-list.a11y, accessibility/mobile-workflows, active-claims-search-clear,
    ConfidenceMeter

npx playwright test --list e2e/e2e/production-route-smoke.spec.ts
  → 14 tests listed (previously unparsable)

npx eslint <every touched file>
  → 0 errors (2 pre-existing unused-symbol warnings)

npx tsc --noEmit  |  grep <touched files>
  → 0 errors in every touched file, except ConfidenceMeter.test.tsx, which is
    blocked by the repo-wide missing jest-axe type augmentation

Repo-wide, on the merged tree:

Gate	main @ 9d200c7	This PR
eslint src	crash at config load	runs: 41 errors / 215 warnings, 0 in touched files
tsc --noEmit	500 errors / 115 files	338 errors, 0 in touched files

(The counts moved between the two columns partly because upstream landed its own baseline work; both figures were re-measured after the merge.)

Known baseline gaps (out of scope, untouched)

These remain red on main and are not introduced or worsened by this PR:

• 26 imports of modules that do not exist, e.g. @/components/ui/FormErrorSummary, @/hooks/useFormErrorSummary, @/lib/routes/redirects, @/lib/api/claims, @/lib/telemetry/redact, @/lib/health/composeOperationalHealth, @/components/evidence/evidence-upload-preflight. They block claim-detail-canonical and AdminDashboard suites from loading.
• 41 ESLint errors in unrelated files (react-hooks/refs during render, redundant ARIA roles, unescaped entities, explicit any).
• src/__tests__/integration/offline-read-resilience.test.tsx (6 failures) still imports @/app/(dashboard)/page as a claimant dashboard. 67aa6b9 turned that route into the public landing page without updating the test.
• responsive/mobile-workflows (1 failure): IdentityPage renders an undefined Worldcoin component.
• A full-repo Jest run does not complete — a baseline suite hangs — so the numbers above come from targeted runs, not a green full suite.
• next build and E2E were not run. Note for CI: assertProductionEnv genuinely validates production configuration, so the build job needs real NEXT_PUBLIC_* values; today it fails closed. main's last CI run was red on Lint, Accessibility, Artifacts, and provider drift.

Reviewer notes

• Behaviour changes are limited to the claims-list table and its hook, plus accessibility semantics; each is described in the table above so it can be checked against the V2-FE-109 architecture doc.
• The one eslint-disable (jsx-a11y/no-noninteractive-tabindex) covers the scrollable data-table region. The rule has no scroll-container exception, and the responsive contract requires tabindex="0" for keyboard scrolling.
• No production data is fabricated anywhere in these changes; all fail-closed paths still fail closed.

Issues

Follow-up to #558 (STAB-FE-003 — Restore the Post-Wave-9 Frontend CI Baseline), which tracks the repo-wide remainder listed above.

Related: #378 (V2-FE-109 — Stabilize Claim Search, Filtering, and Pagination) and #636 (UI-FE-065 — Add Production-Build Smoke Coverage for Every Canonical Route).

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Repository: DigiNodes/truthbounty-frontend/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: b2182a2b-3459-434b-a707-1b7e49270b08

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[dDevAhmed]

resolve conflicts @felixumeh