Dgbnoob/digibyte.wiki#247
Conversation
Sbosvk
left a comment
Sbosvk
left a comment
There was a problem hiding this comment.
Very interesting to see that despite so many conversations about this, we are now seeing Jared Tate biography re-introduced to a DigiByte wiki.
There are probably more links and other irrelevant info. I mostly wanted to highlight that there are some. I have not made a full review.
|
|
||
| ## Contribution Workflow | ||
|
|
||
| 1. Fork the [DigiByte Wiki GitHub Repository](https://github.com/dgbat/digibyte-wiki) to your GitHub account. |
|
|
||
| Our wiki platform runs on Wiki.js, a modern and user-friendly platform for documentation. To ensure your contributions are compatible with our platform, please refer to our [Markdown Guide](https://wiki.digibyte.org/en/contribute/markdown-guide). | ||
|
|
||
| ## Discussion and Comments |
There was a problem hiding this comment.
This entire section is irrelevant when hosted as GitHub wiki
| 2. **HTML**: Contributions in HTML are accepted but are not the preferred format. Ensure that your HTML is well-structured and compliant. | ||
| 3. **Plaintext**: While plaintext contributions are accepted, they should be used sparingly, as they offer limited formatting options. | ||
|
|
||
| ## Wiki Platform |
|
|
||
| ## Cloning the Repository | ||
|
|
||
| 1. **Fork the Repository**: Click the <kbd>Fork</kbd> button on the [DigiByte Wiki GitHub Repository](https://github.com/dgbat/digibyte-wiki) to create a copy in your GitHub account. |
| git push origin feature/descriptive-branch-name | ||
| ``` | ||
|
|
||
| 2. **Create a Pull Request (PR)**: Navigate to the [DigiByte Wiki GitHub Repository](https://github.com/DigiByte-Core/digibyte/wiki), click on "New Pull Request," and choose your branch. |
|
@Sbosvk thank you for reviewing. Your comments make sense and good attention to detail. The information I added to the wiki files was to have a source of information to link DigiByte .org to GitHub wiki. Thank you for pointing out the old links and that the contribution guidelines need to be updated to reflect the correct contribution guidelines. I added Jareds bio specifically to have a source to match the W Biography link that is on DigiByte .org. If the reviewers want it out we can remove it and the W Biography link on DigiByte .org. I created an issue on DigiByte .org pointing out the embedded links to dgbwiki .com (old wiki), if this PR is approved then we can update the DigiByte .org links to GitHub wiki. Oliver, |
|
I see. I think considering that there has been discussions about making the website more actual dgb protocol centric, I assumed things like biographies would also be removed together with socials links. If not,one has to question the real reason for the initiative to clean up the website. I don't see why anyone would care about Jared's life more than any other contributors over the years. Maybe we should write biographies on all of them...you see my point? |
|
I would remove any biographies. |
|
Closing pull request at this time. |
|
Why closed? :) |
|
I closed the PR because when I was working on my local repository I was only trying to push the changes I made but all the files were pushed. I’m working on figuring out the git process and also will make edits to the discrepancies you pointed out. Thank you again for your feedback, I went back and read the proposed changes and you’re correct about making the website DigiByte centric. |
|
Aha I see. Git can take some time understanding. Sometimes the best way is the quick way. :) |
4 participants
I added technical implementations to the terminology file and edited the format (e.g. header, bold, italic and bullet points). I created a biography file for Jared Tate. Included the 0.5% pre-mine details in home file. I think this gives us a good base to update some of the digibyte .org embedded wiki links. Please feel free to edit and add more details if needed.