Added skill to turn on/off the phone flashlight - #374
Merged
Merged
Conversation
Inhishonor
reviewed
Dec 17, 2025
Stypox
previously approved these changes
Feb 21, 2026
Collaborator
There was a problem hiding this comment.
Thank you! I pushed some improvements to the error handling (just showing a generic error message while swallowing the exception is generally not a good idea), and improved the sentences (no need for () around | groups, and moreover the sentences could be compacted).
Also thanks to Inhishonor for the review!
Co-authored-by: Inhishonor <inhishonor@protonmail.com>
…ghtSkill.kt Co-authored-by: Inhishonor <inhishonor@protonmail.com>
Stypox
force-pushed
the
add-flashlight-skill
branch
from
February 21, 2026 17:46
cc24545 to
36ccf86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty basic implementation but it works! The sentences might need some work, I could see it interfering with smart home functions in the future (specifically the "turn on/off the light".
Resolves #341