add german media sentences - #309
Merged
Merged
Conversation
Fadikkop
reviewed
May 19, 2025
Fadikkop
reviewed
May 19, 2025
Fadikkop
reviewed
May 19, 2025
Fadikkop
approved these changes
May 19, 2025
Fadikkop
left a comment
Fadikkop
left a comment
Contributor
There was a problem hiding this comment.
Would like to see this, looks good!
Maybe we could test possible misunderstandings through vosk, but otherwise I'll take it like this.
acidcoke
reviewed
May 21, 2025
Contributor
|
maybe also "hörbuch,hörspiel,podcast"? |
Contributor
|
@tiptoptom You may want to add the changes in #326. I added a sentence for the lyrics skill. |
Stypox
approved these changes
Jul 2, 2025
Stypox
left a comment
Stypox
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This is approved from my side, but I'll wait for @Inhishonor to approve too before mergin, since I don't know if their last comment was for requesting changes
Contributor
Author
Maybe, but this is about a different skill. |
Collaborator
|
Oh ok, then in case you can open another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.