Conversation
Closed
Doomsdayrs
previously approved these changes
Feb 1, 2023
Doomsdayrs
left a comment
Doomsdayrs
left a comment
There was a problem hiding this comment.
Overall, a typical easy java -> kotlin conversion.
| @@ -1,5 +1,8 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
Converting the gradle scripts to kotlin will help too, Would you like me to handle it?
Collaborator
Author
There was a problem hiding this comment.
Why do you think converting gradle scripts to kotlin is a good idea? Does it have a clearer syntax than Groovy? Did the research myself. Yes this is a good idea. Could you handle it, in a separate PR, please? I have no experience at all in Kotlin-for-gradle. ;-)
|
Tested the app, All good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll let this PR out for a while so that we can check if everything still works fine.
Closes #96
Debug APK: app-debug.zip
Release APK: app-release.zip