Merged
Conversation
For rare cases where there's multiple methods with the same name (for example, `paganin_filter` exists in both `httomolib` and `httomolibgpu`), using only the method name as the key for the elements in the accordion isn't sufficient for uniqueness.
For rare cases where there are multiple methods within a group of methods with the same name (ie, `paganin_filter` from `httomolib` and `httomolibgpu` in the "Phase Retrieval" group), toggling one would toggle all with the same name.
`httomolibgpu` has depended on this since [here](DiamondLightSource/httomolibgpu@d26c216), and since `httomolibgpu` is always installed in the tomohub backend with `--no-deps`, this transitive dependency won't get installed when installing `httomolibgpu`. Thus, it must instead be listed as a dependency of the tomohub backend.
yousefmoazzam
force-pushed
the
update-hardcoded-methods-info
branch
from
41cb2cf to
64d4981
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to support methods available in httomolibgpu v5.4