Skip to content

fix(fdroid): strip AGP "Dependency metadata" signing block - #55

Merged
Devasy merged 1 commit into
mainfrom
fdroid/strip-dependency-metadata
Jun 17, 2026
Merged

fix(fdroid): strip AGP "Dependency metadata" signing block#55
Devasy merged 1 commit into
mainfrom
fdroid/strip-dependency-metadata

Conversation

@Devasy

@Devasy Devasy commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Why

F-Droid's APK scanner fails MR !40630 with Found extra signing block 'Dependency metadata'. AGP embeds a Protobuf dependency list in an extra APK signing block (for Google Play); F-Droid disallows extra signing blocks.

What

android { dependenciesInfo { includeInApk = false; includeInBundle = false } } — removes the block. No functional impact (only Play consumes it).

Merging triggers the CI bump + tag (→ v2.0.4), which fdroiddata MR !40630 will point its build at.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed app distribution compatibility with F-Droid by resolving metadata signing conflicts that prevented successful deployment.

F-Droid's APK scanner rejects the build with "Found extra signing block
'Dependency metadata'". That block is the Protobuf dependency list AGP embeds
in the APK signing block for Google Play; F-Droid disallows extra signing
blocks. Disable it via dependenciesInfo { includeInApk/includeInBundle = false }.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Devasy
Devasy merged commit 1b14ee1 into main Jun 17, 2026
3 checks passed
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a5fc6469-d555-411a-a331-43c0014d1cfd

📥 Commits

Reviewing files that changed from the base of the PR and between 95dbae5 and 23ab592.

📒 Files selected for processing (1)
  • workout-logger/android/app/build.gradle.kts

Walkthrough

Adds an android { dependenciesInfo { ... } } block to build.gradle.kts that sets includeInApk = false and includeInBundle = false, removing the AGP-generated dependency metadata signing block from APK and app bundle outputs.

Changes

F-Droid APK Compatibility

Layer / File(s) Summary
Disable dependenciesInfo in APK and bundle
workout-logger/android/app/build.gradle.kts
Adds dependenciesInfo { includeInApk = false; includeInBundle = false } inside the android {} block to strip the AGP dependency metadata signing block from generated APK and app bundle artifacts.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Devasy
Devasy deleted the fdroid/strip-dependency-metadata branch June 17, 2026 17:42
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.54%. Comparing base (b9bdc20) to head (23ab592).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   38.54%   38.54%           
=======================================
  Files          85       85           
  Lines       14088    14088           
=======================================
  Hits         5430     5430           
  Misses       8658     8658           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant