Skip to content

fix(fdroid): make release signing survive F-Droid key stripping - #54

Merged
Devasy merged 1 commit into
mainfrom
fdriod/fix-unmerged
Jun 17, 2026
Merged

fix(fdroid): make release signing survive F-Droid key stripping#54
Devasy merged 1 commit into
mainfrom
fdriod/fix-unmerged

Conversation

@Devasy

@Devasy Devasy commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Why

The F-Droid build of RepForge fails with SigningConfig with name 'release' not found. F-Droid's build server strips the signingConfigs { ... } block before building; the old val releaseConfig = signingConfigs.getByName("release") line survived stripping and referenced the now-removed config.

What

  • build.gradle.kts: collapse signing selection into a single signingConfig = ... statement (findByName + takeIf) that F-Droid's stripper removes whole, so it falls back to its own signing. Local/CI release signing behaviour is unchanged.
  • fastlane/.../short_description.txt: 83 → 71 chars (F-Droid pulls this as Summary; 80-char max).

Merging triggers the CI patch bump + tag (→ v2.0.3), which the fdroiddata MR #40630 will then point its build at.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated app store listing description to clarify the app's analytics capabilities and Health Connect integration features.

F-Droid's build server deletes the `signingConfigs { ... }` block before
building. The old `val releaseConfig = signingConfigs.getByName("release")`
line survived that stripping and then referenced the removed config, failing
with "SigningConfig with name 'release' not found".

Collapse it to a single `signingConfig = ...` statement (which the stripper
removes whole) using findByName + takeIf, so F-Droid falls back to its own
signing. Local/CI release signing is unchanged.

Also shorten the fastlane short_description to 71 chars; F-Droid pulls it as
the Summary (80-char max) and the previous text was 83.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Devasy
Devasy merged commit b9bdc20 into main Jun 17, 2026
3 checks passed
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f3e5bdfe-2c5e-46ad-b060-91b350d1a9db

📥 Commits

Reviewing files that changed from the base of the PR and between 9617fc3 and ca221f2.

📒 Files selected for processing (2)
  • workout-logger/android/app/build.gradle.kts
  • workout-logger/fastlane/metadata/android/en-US/short_description.txt

Walkthrough

The release signing configuration in build.gradle.kts is refactored from a multi-line local variable and conditional block into a single-line expression that falls back to the debug signing config when no release storeFile is present. The Fastlane short_description.txt drops "progress" from "progress analytics."

Changes

Android Build Config and Store Metadata

Layer / File(s) Summary
Release signing config single-line expression
workout-logger/android/app/build.gradle.kts
signingConfig is now assigned via a single-line null-check on the release config's storeFile, falling back to debug; comments are updated to document CI and F-Droid expectations.
Fastlane short description text update
workout-logger/fastlane/metadata/android/en-US/short_description.txt
Description changes from "progress analytics" to "analytics" in the app store short description.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Devasy
Devasy deleted the fdriod/fix-unmerged branch June 17, 2026 14:47
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.54%. Comparing base (3feb70d) to head (ca221f2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   38.54%   38.54%           
=======================================
  Files          85       85           
  Lines       14088    14088           
=======================================
  Hits         5430     5430           
  Misses       8658     8658           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant