fix(fdroid): make release signing survive F-Droid key stripping - #54
Conversation
F-Droid's build server deletes the `signingConfigs { ... }` block before
building. The old `val releaseConfig = signingConfigs.getByName("release")`
line survived that stripping and then referenced the removed config, failing
with "SigningConfig with name 'release' not found".
Collapse it to a single `signingConfig = ...` statement (which the stripper
removes whole) using findByName + takeIf, so F-Droid falls back to its own
signing. Local/CI release signing is unchanged.
Also shorten the fastlane short_description to 71 chars; F-Droid pulls it as
the Summary (80-char max) and the previous text was 83.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe release signing configuration in ChangesAndroid Build Config and Store Metadata
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 38.54% 38.54%
=======================================
Files 85 85
Lines 14088 14088
=======================================
Hits 5430 5430
Misses 8658 8658 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Why
The F-Droid build of RepForge fails with
SigningConfig with name 'release' not found. F-Droid's build server strips thesigningConfigs { ... }block before building; the oldval releaseConfig = signingConfigs.getByName("release")line survived stripping and referenced the now-removed config.What
build.gradle.kts: collapse signing selection into a singlesigningConfig = ...statement (findByName + takeIf) that F-Droid's stripper removes whole, so it falls back to its own signing. Local/CI release signing behaviour is unchanged.fastlane/.../short_description.txt: 83 → 71 chars (F-Droid pulls this as Summary; 80-char max).Merging triggers the CI patch bump + tag (→ v2.0.3), which the fdroiddata MR #40630 will then point its build at.
🤖 Generated with Claude Code
Summary by CodeRabbit