Skip to content

Fix WASM Build Error and Implement Data Access Layer - #5

Merged
Devasy merged 2 commits into
feat/create-expo-app-12256726095476018075from
data-access-layer-and-build-fix-14736182564595119881
Dec 23, 2025
Merged

Fix WASM Build Error and Implement Data Access Layer#5
Devasy merged 2 commits into
feat/create-expo-app-12256726095476018075from
data-access-layer-and-build-fix-14736182564595119881

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This PR fixes a build error where .wasm files were being parsed as JavaScript by the Metro bundler, causing a SyntaxError. It updates metro.config.js to correctly handle .wasm files as assets. Additionally, it implements the Data Access Layer (Step 2) with repositories for Workouts, Exercises, Sets, and Analytics using the Repository pattern.


PR created automatically by Jules for task 14736182564595119881 started by @Devasy23

- Update `metro.config.js` to treat .wasm files as assets to fix web build SyntaxError
- Create `workout-logger/repositories/WorkoutRepository.js`
- Create `workout-logger/repositories/ExerciseRepository.js`
- Create `workout-logger/repositories/SetRepository.js`
- Create `workout-logger/repositories/AnalyticsRepository.js`
- Implements step 2 of the documentation (Data Access Layer)
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@coderabbitai

coderabbitai Bot commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Devasy
Devasy marked this pull request as ready for review December 23, 2025 19:29
…cess-layer-and-build-fix-14736182564595119881
@Devasy
Devasy merged commit ce187c4 into feat/create-expo-app-12256726095476018075 Dec 23, 2025
1 check passed
@Devasy
Devasy deleted the data-access-layer-and-build-fix-14736182564595119881 branch December 23, 2025 19:30
Devasy added a commit that referenced this pull request Aug 11, 2026
- Remove Finalizer mechanism and unused imports (dart:async)
- Remove _tempDatabasePath and _generatedTempPath fields
- Simplify init() to convert :memory: to temp files without tracking
- Add deterministic tearDown() in test to close database and delete temp files
- Verified: no temp file leaks, all 35 tests passing

Closes: finding #5 from previous review

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant