Repository navigation
fix(chat): make inline web citations clickable - #599
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: bc4bd8d3-fe9d-42b2-b343-9f3256426d0d) |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat answers displayed
[Source N]as plain text even though each answer already retained the source URLs. Resolve those labels against the answer’s own web-source metadata so clicking a citation opens the matching page in a new tab, with the source title on hover. This covers streamed and saved answers, stopped/error answers, and proposed plans.The Markdown renderer links only known HTTP(S) sources and preserves citation examples inside code and existing links. Unknown citation numbers remain plain text; document citation navigation is unchanged.
Validation: 83 tests passed across ChatMarkdown, AskPanel citations/timeline, and useChatRuntime; web TypeScript checking and targeted ESLint passed. A local Next.js browser check confirmed that completing a response produces inline links and clicking
[Source 1]opens the expected vLLM Docker documentation in a new tab.Note
Medium Risk
New automatic outbound links from chat content rely on URL allowlisting; document citation chips and behavior are unchanged but misclassified tool URLs could still mislead users.
Overview
Chat answers that include
[Source N]labels now render as clickable links resolved from each message’swebSourcesmetadata (tool-returned URLs), instead of staying plain text.ChatMarkdowngains alinkWebCitationsrehype step that maps numbered citations to safe HTTP(S) URLs viasafeChatUri, skipscode/pre/existing links, and leaves unknown or unsafe sources as text.AskPanel,AnswerProse, andProposedPlanthreadwebSourcesthrough so streaming, stopped/error, saved, and plan-mode answers all link consistently when metadata arrives.Tests cover multi-citation answers, delayed
webSourceson stream, plan UI, per-answer source isolation, and rejected malicious URLs.Reviewed by Cursor Bugbot for commit cf9c3f2. Bugbot is set up for automated code reviews on this repo. Configure here.