Skip to content

Add Guide to @wordpress/components - #58077

Merged
typescript-bot merged 3 commits into
DefinitelyTyped:masterfrom
sirbrillig:add-guide-wordpress-components
Jan 10, 2022
Merged

typescript-bot merged 3 commits into
DefinitelyTyped:masterfrom
sirbrillig:add-guide-wordpress-components

Conversation

@sirbrillig

Copy link
Copy Markdown
Contributor

This PR adds types for Guide to the @wordpress/components package.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot

typescript-bot commented Jan 9, 2022 •

Copy link
Copy Markdown
Contributor

@sirbrillig Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58077,
  "author": "sirbrillig",
  "headCommitOid": "3bd36220e828a7f2790fe9970243d03eecf28475",
  "mergeBaseOid": "95ff90d628723ec4bae27db2e744b2564b5fe02f",
  "lastPushDate": "2022-01-10T16:13:39.000Z",
  "lastActivityDate": "2022-01-10T18:56:15.000Z",
  "mergeOfferDate": "2022-01-10T18:54:58.000Z",
  "mergeRequestDate": "2022-01-10T18:56:15.000Z",
  "mergeRequestUser": "sirbrillig",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wordpress__components",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__components/guide/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__components/wordpress__components-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "p-jackson",
        "sarayourfriend"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "martin-badin",
      "date": "2022-01-10T18:54:21.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1008345162,
  "ciResult": "pass"
}

@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @dsifford @sirreal @p-jackson @sarayourfriend — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS

DangerBotOSS commented Jan 9, 2022 •

Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

wordpress__components (unpkg)

was missing the following properties:

  1. ComboboxControl
  2. DuotoneSwatch
  3. DuotonePicker
  4. GuidePage
  5. TextHighlight
as well as these 4 other properties...

Tip, ToolbarGroup, ToolbarItem, VisuallyHidden

Generated by 🚫 dangerJS against 3bd3622

@martin-badin martin-badin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jan 10, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

@sirbrillig One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Co-authored-by: martin-badin <martin.badin@gmail.com>
@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR and removed Revision needed This PR needs code changes before it can be merged. Where is GH Actions? GH Actions didn't give a response to this PR labels Jan 10, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

@martin-badin Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@martin-badin martin-badin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 10, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

@sirbrillig: Everything looks good here. I am ready to merge this PR (at 3bd3622) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dsifford, @sirreal, @p-jackson, @sarayourfriend: you can do this too.)

@sirbrillig

Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot
typescript-bot merged commit a6f3766 into DefinitelyTyped:master Jan 10, 2022
martin-badin added a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
…@sirbrillig

* Add Guide to wordpress/components

* Run Prettier

* Add detailed deprecation message for children in Guide

Co-authored-by: martin-badin <martin.badin@gmail.com>

Co-authored-by: martin-badin <martin.badin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants