Repository navigation
Add Guide to @wordpress/components - #58077
typescript-bot merged 3 commits into
Conversation
|
@sirbrillig Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58077,
"author": "sirbrillig",
"headCommitOid": "3bd36220e828a7f2790fe9970243d03eecf28475",
"mergeBaseOid": "95ff90d628723ec4bae27db2e744b2564b5fe02f",
"lastPushDate": "2022-01-10T16:13:39.000Z",
"lastActivityDate": "2022-01-10T18:56:15.000Z",
"mergeOfferDate": "2022-01-10T18:54:58.000Z",
"mergeRequestDate": "2022-01-10T18:56:15.000Z",
"mergeRequestUser": "sirbrillig",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "wordpress__components",
"kind": "edit",
"files": [
{
"path": "types/wordpress__components/guide/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__components/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__components/wordpress__components-tests.tsx",
"kind": "test"
}
],
"owners": [
"dsifford",
"sirreal",
"p-jackson",
"sarayourfriend"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "martin-badin",
"date": "2022-01-10T18:54:21.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1008345162,
"ciResult": "pass"
} |
|
🔔 @dsifford @sirreal @p-jackson @sarayourfriend — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. wordpress__components (unpkg)was missing the following properties:
as well as these 4 other properties...Tip, ToolbarGroup, ToolbarItem, VisuallyHidden |
|
@sirbrillig One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Co-authored-by: martin-badin <martin.badin@gmail.com>
|
@martin-badin Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@sirbrillig: Everything looks good here. I am ready to merge this PR (at 3bd3622) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@dsifford, @sirreal, @p-jackson, @sarayourfriend: you can do this too.) |
|
Ready to merge |
…@sirbrillig * Add Guide to wordpress/components * Run Prettier * Add detailed deprecation message for children in Guide Co-authored-by: martin-badin <martin.badin@gmail.com> Co-authored-by: martin-badin <martin.badin@gmail.com>
This PR adds types for
Guideto the@wordpress/componentspackage.npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: