Note is sometimes updates while opening

[vitonsky]

When I open a note just by click it, the note updates and goes to the notes list top.

That is unexpected behaviour, since i did not changed a note content.

This behaviour makes difficult a notes exploring.

I use a rich editor.

I don't know exact steps, but when that happens, i noticed the history changes, and new entry in history have different chars counter.

I think the problem is RichEditor changes the text when open a note, and writes a changes. We should find a minimal steps to reproduce first.

[vitonsky]

I found a steps, but I'm not sure there are only one way to reproduce that bug.

• Use plain text editor mode
• Add note with text The text with a [link](https://example.org "The title")
• Add another note
• Close both notes
• Toggle editor mode to a "rich editor"
• Open note with link

Current behaviour:

• Note opens
• Rich editor parse text and save it as The text with a [link](https://example.org) (the link title is discarder)
• The note is updated and is on top of the notes list

[vitonsky]

As one of possible solutions we could prevent note updates in case user open the note and had no intention to update its content.

For example, we could drop any updates until user would press any key while focus on note. But we must consider all the ways how the user can express the intent to change a note content.

[katsyuta]

@vitonsky, Instead of updating data only on user actions, we can ignore changes made by non-users.

I checked the current flow, and now it works as follows in MarkdownSerializePlugin:

• External value update (value prop changes)
• Value changes, which triggers useEffect
• Call editor.update() to apply new markdown
• Editor state updates, OnChangePlugin fires
• Call sync function (after this call, the note updates)

The problem is that the change was not made by the user, but by serializing the external value into markdown. We can ignore such changes and not update the note in this case.

At the same time, any changes made by the user will continue to be handled via OnChangePlugin, and when the user makes changes, we call the sync function, and the note will be updated.