Handle Kafka tombstone records in topic assertions #564 - #901
Open
AzazelSensei wants to merge 2 commits into
Open
AzazelSensei wants to merge 2 commits into
AzazelSensei wants to merge 2 commits into
Conversation
Null-value records no longer NPE in the_topic_contains. Publishing value: null now sends a real tombstone instead of the JSON string null.
|
|
Collaborator
|
@AzazelSensei thanks for your first contribution! Awesome! Could you please sign the CLA so that we can merge your work and make it available in the next version of Tzatziki? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the topic containsNPEd on a null record value, so you could not assert a tombstone.I map a null payload as null instead of calling
toString(), andvalue: nullon publish now sends a real tombstone. Added a json scenario that publishes one and asserts it.Fixes #564