Selection export + toolbar changes - #63
Merged
Merged
Conversation
Deploying tools with
|
| Latest commit: |
937f136
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2d2c5d7.tellraw-aav.pages.dev |
| Branch Preview URL: | https://feature-selection-export.tellraw-aav.pages.dev |
HoodieRocks
approved these changes
Aug 12, 2026
HoodieRocks
left a comment
HoodieRocks
left a comment
Contributor
There was a problem hiding this comment.
LGTM, feel free to fix the comments before merging
Comment on lines
+134
to
+145
| // onSelectionUpdate: ({ editor }) => { | ||
| // const { state } = editor; | ||
| // const { from, to, empty } = state.selection; | ||
|
|
||
| // // Do nothing if it's just a cursor click without a highlighted range | ||
| // if (empty) return; | ||
|
|
||
| // // Extract the selection slice as JSON | ||
| // const selectionJson = state.doc.slice(from, to).content.toJSON(); | ||
|
|
||
| // console.log("Selected content as JSON:", selectionJson); | ||
| // } |
Contributor
There was a problem hiding this comment.
Remove commented out code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.