[java] Enable test_stable_configuration_config_id #5062
Merged
Conversation
mhlidd
approved these changes
Sep 15, 2025
|
|
||
| @missing_feature(context.library in ("java", "nodejs"), reason="Not implemented") | ||
| @missing_feature(context.library == "nodejs", reason="Not implemented") | ||
| @missing_feature(context.library <= "java@v1.53.0-SNAPSHOT", reason="Not implemented") |
Contributor
There was a problem hiding this comment.
Should this just be 1.53.0?
Contributor
Author
There was a problem hiding this comment.
It could be, but I made that modification before the change was publicly available in dd-trace-java; using -SNAPSHOT allows us to make the change once, during development, without having to go back and update it again.
@cbeauchesne , what do you think?
Collaborator
There was a problem hiding this comment.
Exactly, that's the right way to do that
chagui
pushed a commit
that referenced
this pull request
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Java newly reports config ID for stable config sources
Changes
Enables test_stable_configuration_config_id test for Java v1.53.0+
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present