Skip to content

Less verbose curl health checks #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smola merged 1 commit into from
Aug 8, 2023
Merged

Less verbose curl health checks #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions utils/_context/containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,10 @@ def __init__(self, host_log_folder, use_proxy=True) -> None:
name="agent",
host_log_folder=host_log_folder,
environment=environment,
healthcheck={"test": f"curl --fail http://localhost:{self.agent_port}/info", "retries": 60},
healthcheck={
"test": f"curl --fail --silent --show-error http://localhost:{self.agent_port}/info",
"retries": 60,
},
ports={self.agent_port: f"{self.agent_port}/tcp"},
)

Expand Down Expand Up @@ -334,7 +337,7 @@ def __init__(
# ddprof's perf event open is blocked by default by docker's seccomp profile
# This is worse than the line above though prevents mmap bugs locally
security_opt=["seccomp=unconfined"],
healthcheck={"test": f"curl --fail localhost:{weblog.port}", "retries": 60},
healthcheck={"test": f"curl --fail --silent --show-error localhost:{weblog.port}", "retries": 60},
ports={"7777/tcp": weblog.port, "7778/tcp": weblog._grpc_port},
)

Expand Down