Fix the oci_push runfiles with the new transitive blob_indices support - #142
Merged
Merged
Conversation
…pport #141 forgot to add the new files to the runfiles... oops. This breaks at build time with the following error: ``` failed to load layout (../python_3_12_8/layout.layout.json): couldn't open index: open ../python_3_12_8/layout.layout.json: no such file or directory ```
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
andrew-lockwood
approved these changes
Sep 9, 2026
BryceBeagle
commented
Sep 9, 2026
| is_executable = True, | ||
| ) | ||
|
|
||
| runfiles = ctx.runfiles( |
Contributor
Author
There was a problem hiding this comment.
we also change this to use runfiles properly. Using .to_list() was definitely wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#141 forgot to add the new files to the runfiles... oops.
This breaks at build time with the following error: