Namespace datadog blackhole target metrics & default off - #1926
Namespace datadog blackhole target metrics & default off#1926GeorgeHahn wants to merge 2 commits into
Conversation
GeorgeHahn
changed the title
GeorgeHahn
changed the title
Datadog blackhole now prefixes recorded metric names with target/, matching the prometheus and expvar target metrics collectors. The record policy continues to match on the unprefixed series name. Also changes the default record policy to Disabled, so no target metrics are recorded unless explicitly configured. Both are breaking changes for consumers relying on unprefixed metric names or default-all recording behavior.
This comment has been minimized.
This comment has been minimized.
| use crate::proto::datadog::intake::metrics::MetricPayload; | ||
|
|
||
| /// Namespace for incoming metrics; matches other target-originated metrics. | ||
| const TARGET_PREFIX: &str = "target/"; |
There was a problem hiding this comment.
Does this imply that we'll have a metric rename happening?
My concern is with the variety of dashboards/tools/scripts that already exist that use these.
There was a problem hiding this comment.
Yes for experiments that use the datadog blackhole. Those experiments will also need adjustment to explicitly opt into target metric collection.
preinlein
left a comment
preinlein
left a comment
There was a problem hiding this comment.
There's no clean way to double-emit and do a "migration" with our users. We'll have to let this be a breaking change, make comms, and let our on-call know.
| ## Unreleased | ||
|
|
||
| ## Changed | ||
| - **Breaking Change**: Datadog blackhole now records received series under the |
There was a problem hiding this comment.
Ok, that answers my previous question.
Going to approve but we should let the team/users know when we do the release.
There was a problem hiding this comment.
Absolutely yeah. I'll land the experiment changes along with teams' update PRs and keep the breaking notes in the public announcement.
d396c37 to
6ea30a5
Compare
2 participants
Two breaking changes: