Variable renaming in support of a PR into dd-agent - #455
Closed
AlexTawse wants to merge 1 commit into
Closed
Conversation
hkaj
requested changes
Jun 2, 2017
hkaj
left a comment
hkaj
left a comment
Member
There was a problem hiding this comment.
one comment on the import, everything else is 👍
| RANCHER_STACK_NAME) | ||
| SWARM_SVC_LABEL) | ||
| from utils.kubernetes import KubeUtil | ||
| from utils.rancher import RancherUtil |
Member
There was a problem hiding this comment.
will need to move to L24 after the directory move in DataDog/dd-agent#3366
|
This PR has been automatically marked as stale because it has not had activity in the last 60 days. Note that the PR will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community. |
Contributor
|
Still waiting on sister PR DataDog/dd-agent#3366, setting the milestone accordingly |
Contributor
|
Closing as we won't merge DataDog/dd-agent#3366, details here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
See this PR for details: DataDog/dd-agent#3366
Additional Notes
Depends on, and is dependent of, this PR: DataDog/dd-agent#3366
The build will likely fail until this PR is merged.