Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3357 +/- ##
==========================================
+ Coverage 79.11% 85.06% +5.94%
==========================================
Files 153 70 -83
Lines 7747 5978 -1769
Branches 945 761 -184
==========================================
- Hits 6129 5085 -1044
+ Misses 1395 723 -672
+ Partials 223 170 -53 |
Codecov Report
@@ Coverage Diff @@
## master #3357 +/- ##
==========================================
+ Coverage 79.11% 85.73% +6.61%
==========================================
Files 153 726 +573
Lines 7747 39999 +32252
Branches 945 4933 +3988
==========================================
+ Hits 6129 34292 +28163
- Misses 1395 4347 +2952
- Partials 223 1360 +1137 |
ofek
approved these changes
Mar 26, 2019
Contributor
|
Superseded by #3443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the upgrade to prometheus_client 0.6.0 breaks so many tests in #3275 .
this current PR tries to investigate and adapt our code so we can upgrade prometheus_client from 0.3.0 to 0.6.0
More context:
The reason behind tests failure is this commit prometheus/client_python@a4dd93b it makes counter metric name not have _total internally. released since 0.4.0 prometheus/client_python#300 , we rely on the function
text_fd_to_metric_families(changed in 0.4.0) in our openmetrics logic which is used by multiple integrationsMotivation
same motivation as #3275