Add dynamic_service DBM propagation mode#3940
Open
amarziali wants to merge 2 commits into
Open
Conversation
|
Benchmarks [ tracer ]Benchmark execution time: 2026-05-29 15:05:32 Comparing candidate commit 59ce771 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
|
bwoebi
reviewed
May 29, 2026
36e2576 to
59ce771
Compare
59ce771 to
e7a2006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new DBM propagation mode value,
dynamic_service, as a convenience alias for the combination ofDD_DBM_PROPAGATION_MODE=serviceandDD_DBM_INJECT_SQL_BASEHASH=true. With a single setting, users get service-level SQL comment propagation (dddbs,ddps, etc.) plus the process-tags base hash injected asddshin the SQL comment and_dd.propagated_hashon the span, without needing to manage two separate variables.Behavior:
servicemode: notraceparentheader, no_dd.dbm_trace_injectedspan tagddsh/_dd.propagated_hash) is always injected regardless ofDD_DBM_INJECT_SQL_BASEHASHPlease note that this mode will replace
serviceon the long term (and hence eventually also theDD_DBM_INJECT_SQL_BASEHASHwill be deprecated/removed at same time)Reviewer checklist