Skip to content

chore(vendor): [DO NOT MERGE] test orchestrion-js#102 fast path - #10586

Draft
pabloerhard wants to merge 1 commit into
masterfrom
pabloerhard/test-orchestrion-fast-path
Draft

pabloerhard wants to merge 1 commit into
masterfrom
pabloerhard/test-orchestrion-fast-path

Conversation

@pabloerhard

Copy link
Copy Markdown
Contributor

What does this PR do?

Testing only — do not merge. Points the vendored @apm-js-collab/code-transformer at the head commit of nodejs/orchestrion-js#102 (980470b, based on v0.18.1) so the full CI matrix exercises our Orchestrion integrations against it.

Motivation

nodejs/orchestrion-js#102 moves the subscriber check ahead of the per-call context allocation in generated wrappers. This PR checks whether any dd-trace-js Orchestrion integration or custom transform (packages/datadog-instrumentations/src/helpers/rewriter/transforms.js) depends on the old wrapper shape or ordering.

Additional Notes

  • The only change is vendor/package.json and vendor/package-lock.json, which now use a GitHub dependency (git+https). The rest of the lockfile is unchanged.
  • Locally, packages/datadog-instrumentations/test/helpers/rewriter/index.spec.js passes (66 tests).
  • Close this PR once CI results are collected.

Points @apm-js-collab/code-transformer at the head commit of
nodejs/orchestrion-js#102 (980470b, based on v0.18.1) so the full CI
matrix exercises our Orchestrion integrations against it. Testing only.
@dd-octo-sts

dd-octo-sts Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.39 MB
Deduped: 10.12 MB
No deduping: 10.12 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.5.1 | 127.66 kB | 513.61 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 4 tests - 4 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 98.25% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 96c0f85 | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.86%. Comparing base (678bad7) to head (96c0f85).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10586   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files        1056     1056           
  Lines      170548   170548           
  Branches       74       74           
=======================================
  Hits       168607   168607           
  Misses       1941     1941           
Flag Coverage Δ
ai-guard 64.06% <ø> (-0.02%) ⬇️
apm-capabilities 54.80% <ø> (ø)
apm-integrations 81.33% <ø> (-0.02%) ⬇️
appsec 57.99% <ø> (-0.01%) ⬇️
debugger 69.81% <ø> (-0.01%) ⬇️
instrumentation 55.46% <ø> (-0.01%) ⬇️
llmobs 80.49% <ø> (-0.02%) ⬇️
master-coverage 98.86% <ø> (?)
openfeature 67.70% <ø> (-0.03%) ⬇️
platform 68.90% <ø> (-0.01%) ⬇️
profiling 66.33% <ø> (-0.03%) ⬇️
serverless 65.83% <ø> (-0.02%) ⬇️
test-optimization 82.14% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Oct 1, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-10-01 20:51:56

Comparing candidate commit 96c0f85 in PR branch pabloerhard/test-orchestrion-fast-path with baseline commit 678bad7 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2386 metrics, 17 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable max_rss_usage [-18449.320KB; +16614.411KB] or [-6.430%; +5.790%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • unstable max_rss_usage [-13.906MB; +9.742MB] or [-6.154%; +4.311%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20

  • unstable max_rss_usage [-27.577MB; +30.046MB] or [-7.861%; +8.565%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-1397.913ms; +922.976ms] or [-15.326%; +10.119%]
  • unstable execution_time [-1459.662ms; +927.834ms] or [-14.265%; +9.067%]
  • unstable throughput [-98.844op/s; +157.005op/s] or [-8.834%; +14.031%]

scenario:dogstatsd-aggregated-20

  • unstable execution_time [-94.642ms; +141.927ms] or [-4.855%; +7.280%]

scenario:dogstatsd-aggregated-26

  • unstable execution_time [-62.353ms; +106.440ms] or [-3.772%; +6.439%]

scenario:encoders-0.4-immediate-flush-20

  • unstable max_rss_usage [-12039.250KB; +12243.250KB] or [-15.446%; +15.708%]

scenario:iast-sink-check-26

  • unstable cpu_user_time [-175.555ms; +266.775ms] or [-4.780%; +7.263%]
  • unstable execution_time [-181.023ms; +259.594ms] or [-4.894%; +7.018%]

scenario:openfeature-scale-full-24

  • unstable max_rss_usage [-3.360MB; +33.806MB] or [-1.130%; +11.367%]

scenario:plugin-aws-sdk-eventbridge-inject-detail-26

  • unstable cpu_usage_percentage [-8.214%; +5.672%]
  • unstable execution_time [-254.360ms; +405.034ms] or [-6.303%; +10.037%]
  • unstable throughput [-132243.334op/s; +83101.084op/s] or [-8.849%; +5.561%]

scenario:plugin-claude-agent-sdk-delayed-noisy-hook-indexed-20

  • unstable execution_time [-295.157ms; +612.164ms] or [-3.534%; +7.329%]

scenario:plugin-graphql-long-with-depth-off-26

  • unstable max_rss_usage [-28.871MB; +18.671MB] or [-11.160%; +7.218%]

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant